Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2281773002: Add --fast-startup flag to test.py (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index f6ac871d57b687986a4905c19e98be5f0716ff69..e008e71adb24544e72abb50f7ceee5b2cc406569 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -57,6 +57,7 @@ abstract class CompilerConfiguration {
bool useBlobs = configuration['use_blobs'];
bool hotReload = configuration['hot_reload'];
bool hotReloadRollback = configuration['hot_reload_rollback'];
+ bool useFastStartup = configuration['fast_startup'];
switch (compiler) {
case 'dart2analyzer':
@@ -74,6 +75,7 @@ abstract class CompilerConfiguration {
useCps: useCps,
useSdk: useSdk,
isCsp: isCsp,
+ useFastStartup: useFastStartup,
extraDart2jsOptions:
TestUtils.getExtraOptions(configuration, 'dart2js_options'));
case 'dart2app':
@@ -264,6 +266,7 @@ class Dart2xCompilerConfiguration extends CompilerConfiguration {
class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
final bool isCsp;
final bool useCps;
+ final bool useFastStartup;
final List<String> extraDart2jsOptions;
// We cache the extended environment to save memory.
static Map<String, String> cpsFlagCache;
@@ -276,6 +279,7 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
bool useSdk,
bool this.useCps,
bool this.isCsp,
+ bool this.useFastStartup,
this.extraDart2jsOptions})
: super('dart2js',
isDebug: isDebug,
@@ -299,6 +303,9 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
Map<String, String> environmentOverrides) {
List compilerArguments = new List.from(arguments)
..addAll(extraDart2jsOptions);
+ if (useFastStartup) {
+ compilerArguments.add('--fast-startup');
+ }
return new CommandArtifact(<Command>[
this.computeCompilationCommand('$tempDir/out.js', buildDir,
CommandBuilder.instance, compilerArguments, environmentOverrides)
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698