Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2281733003:
tools: skp_parser (Closed)
|
Created:
4 years, 3 months ago by hal.canary Modified:
4 years, 2 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionskp_parser
compiles with GN.
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003
Committed: https://skia.googlesource.com/skia/+/a73d76af31d8ad04716fb611d7987dfd1762f5e9
Patch Set 1 : more #Patch Set 2 : rebase #
Total comments: 2
Patch Set 3 : skpparser->skp_parser #
Messages
Total messages: 38 (26 generated)
Description was changed from ========== work in progress COMMIT=false BUG=skia: ========== to ========== work in progress COMMIT=false BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ==========
Description was changed from ========== work in progress COMMIT=false BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ========== to ========== skp_parser compiles with GN. ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== skp_parser compiles with GN. ========== to ========== skp_parser compiles with GN. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Patchset #1 (id:40001) has been deleted
halcanary@google.com changed reviewers: + ethannicholas@google.com
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/26 at 20:04:04, halcanary wrote: > PTAL Does skiaserve still build and run under gyp with these changes? I would like to switch to using GN to build skiaserve, but haven't gotten to it yet, only fiddle has been moved over so far.
On 2016/09/01 17:43:43, jcgregorio wrote: > Does skiaserve still build and run under gyp with these changes? Yes. I just tested it locally.
halcanary@google.com changed reviewers: + jcgregorio@google.com
ping
On 2016/09/26 at 14:14:47, halcanary wrote: > ping Looks fine by me, but I wouldn't trust my C++ as far as I could throw me.
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
halcanary@google.com changed reviewers: + bungeman@google.com
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
https://codereview.chromium.org/2281733003/diff/80001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2281733003/diff/80001/BUILD.gn#newcode964 BUILD.gn:964: executable("skpparser") { Wouldn't you feel better if this were named skp_parser?
lgtm
https://codereview.chromium.org/2281733003/diff/80001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2281733003/diff/80001/BUILD.gn#newcode964 BUILD.gn:964: executable("skpparser") { On 2016/10/17 18:14:05, mtklein_C wrote: > Wouldn't you feel better if this were named skp_parser? Done.
The CQ bit was checked by halcanary@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from ethannicholas@google.com Link to the patchset: https://codereview.chromium.org/2281733003/#ps100001 (title: "skpparser->skp_parser")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by borenet@google.com
Description was changed from ========== skp_parser compiles with GN. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ========== to ========== skp_parser compiles with GN. NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== skp_parser compiles with GN. NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 ========== to ========== skp_parser compiles with GN. NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281733003 Committed: https://skia.googlesource.com/skia/+/a73d76af31d8ad04716fb611d7987dfd1762f5e9 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as https://skia.googlesource.com/skia/+/a73d76af31d8ad04716fb611d7987dfd1762f5e9 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
