Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: cc/resources/image_raster_worker_pool.h

Issue 228173002: cc: Separate RasterWorkerPool interface from implementation details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/direct_raster_worker_pool.cc ('k') | cc/resources/image_raster_worker_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/image_raster_worker_pool.h
diff --git a/cc/resources/image_raster_worker_pool.h b/cc/resources/image_raster_worker_pool.h
index 7720d4bb721ee769ea69f10a38cb92a46ea480c1..91d93732b693eaf79b3dc22eb6e1796f7c9025a9 100644
--- a/cc/resources/image_raster_worker_pool.h
+++ b/cc/resources/image_raster_worker_pool.h
@@ -8,33 +8,37 @@
#include "base/memory/weak_ptr.h"
#include "base/values.h"
#include "cc/resources/raster_worker_pool.h"
+#include "cc/resources/rasterizer.h"
namespace cc {
class ResourceProvider;
class CC_EXPORT ImageRasterWorkerPool : public RasterWorkerPool,
- public internal::WorkerPoolTaskClient {
+ public Rasterizer,
+ public internal::RasterizerTaskClient {
public:
virtual ~ImageRasterWorkerPool();
- static scoped_ptr<ImageRasterWorkerPool> Create(
+ static scoped_ptr<RasterWorkerPool> Create(
base::SequencedTaskRunner* task_runner,
+ internal::TaskGraphRunner* task_graph_runner,
ResourceProvider* resource_provider,
unsigned texture_target);
// Overridden from RasterWorkerPool:
- virtual void SetClient(RasterWorkerPoolClient* client) OVERRIDE;
+ virtual Rasterizer* AsRasterizer() OVERRIDE;
+
+ // Overridden from Rasterizer:
+ virtual void SetClient(RasterizerClient* client) OVERRIDE;
virtual void Shutdown() OVERRIDE;
virtual void ScheduleTasks(RasterTaskQueue* queue) OVERRIDE;
virtual unsigned GetResourceTarget() const OVERRIDE;
virtual ResourceFormat GetResourceFormat() const OVERRIDE;
virtual void CheckForCompletedTasks() OVERRIDE;
- // Overridden from internal::WorkerPoolTaskClient:
- virtual SkCanvas* AcquireCanvasForRaster(internal::WorkerPoolTask* task,
- const Resource* resource) OVERRIDE;
- virtual void ReleaseCanvasForRaster(internal::WorkerPoolTask* task,
- const Resource* resource) OVERRIDE;
+ // Overridden from internal::RasterizerTaskClient:
+ virtual SkCanvas* AcquireCanvasForRaster(internal::RasterTask* task) OVERRIDE;
+ virtual void ReleaseCanvasForRaster(internal::RasterTask* task) OVERRIDE;
protected:
ImageRasterWorkerPool(base::SequencedTaskRunner* task_runner,
@@ -50,7 +54,7 @@ class CC_EXPORT ImageRasterWorkerPool : public RasterWorkerPool,
scoped_refptr<base::SequencedTaskRunner> task_runner_;
internal::TaskGraphRunner* task_graph_runner_;
const internal::NamespaceToken namespace_token_;
- RasterWorkerPoolClient* client_;
+ RasterizerClient* client_;
ResourceProvider* resource_provider_;
const unsigned texture_target_;
@@ -59,8 +63,8 @@ class CC_EXPORT ImageRasterWorkerPool : public RasterWorkerPool,
base::WeakPtrFactory<ImageRasterWorkerPool> raster_finished_weak_ptr_factory_;
- scoped_refptr<internal::WorkerPoolTask> raster_finished_task_;
- scoped_refptr<internal::WorkerPoolTask>
+ scoped_refptr<internal::RasterizerTask> raster_finished_task_;
+ scoped_refptr<internal::RasterizerTask>
raster_required_for_activation_finished_task_;
// Task graph used when scheduling tasks and vector used to gather
« no previous file with comments | « cc/resources/direct_raster_worker_pool.cc ('k') | cc/resources/image_raster_worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698