Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2281653002: Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for oddball drawArcs (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for oddball drawArcs Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws if the oval is empty or the sweep angle is 0. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002 Committed: https://skia.googlesource.com/skia/+/21af9ca1b1f54d9ba1de055aa8475928d5c8ecdf

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -26 lines) Patch
M gm/circulararcs.cpp View 2 chunks +85 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 1 chunk +8 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +39 lines, -0 lines 0 comments Download
M src/core/SkPathPriv.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 3 months ago (2016-08-25 17:53:09 UTC) #3
robertphillips
lgtm
4 years, 3 months ago (2016-08-25 18:09:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281653002/20001
4 years, 3 months ago (2016-08-25 18:38:04 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:29:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/21af9ca1b1f54d9ba1de055aa8475928d5c8ecdf

Powered by Google App Engine
This is Rietveld 408576698