Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 22816026: Convert setup.py to use setuptools (Closed)

Created:
7 years, 4 months ago by ericvw
Modified:
7 years, 3 months ago
CC:
gyp-developer_googlegroups.com, Shezan Baig (Bloomberg)
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Convert setup.py to use setuptools Due to r1667, setup.py was left broken installing 'gyp' as a script, which happened to be the *nix invocation script wrapper. By converting setup.py to use setuptools, when the gyp script is installed, the appropriate file name will be generated to match the local conventions on both *nix and Windows platforms. This change required adding a proxy function in gyp/__init__.py, called 'script_main', which takes 0 arguments as required by setuptools that directly ends up calling 'main' passing along sys.argv[1:]. Other areas in gyp/__init__.py and gyp_main.py were modified to use this new function as well. The MANIFEST file was deleted since setuptools automatically includes the correct files in source distributions. Contributed by ericvw@gmail.com BUG=None

Patch Set 1 #

Patch Set 2 : remove 'scripts' from setup.py #

Patch Set 3 : remove ez_setup.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
D MANIFEST View 1 chunk +0 lines, -19 lines 0 comments Download
M gyp_main.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/__init__.py View 1 chunk +5 lines, -1 line 0 comments Download
M setup.py View 1 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ericvw
7 years, 4 months ago (2013-08-25 03:08:05 UTC) #1
Shezan Baig (Bloomberg)
I tested this locally and it worked. After agl's review, I can commit this on ...
7 years, 3 months ago (2013-08-26 13:38:24 UTC) #2
agl
This seems reasonable, but there's no way that I'm the correct reviewer for this. You ...
7 years, 3 months ago (2013-08-26 14:16:03 UTC) #3
Shezan Baig (Bloomberg)
On 2013/08/26 14:16:03, agl wrote: > This seems reasonable, but there's no way that I'm ...
7 years, 3 months ago (2013-08-26 14:21:49 UTC) #4
Shezan Baig (Bloomberg)
Switching reviewer to sgk
7 years, 3 months ago (2013-08-26 14:22:22 UTC) #5
Shezan Baig (Bloomberg)
7 years, 3 months ago (2013-08-26 14:26:50 UTC) #6
ericvw
Uploaded a new patch that removed 'scripts' from setup.py
7 years, 3 months ago (2013-08-26 16:25:12 UTC) #7
Shezan Baig (Bloomberg)
Hey Scott, can you take a look at this when you have time? Thanks!
7 years, 3 months ago (2013-09-04 14:16:50 UTC) #8
scottmg
On 2013/09/04 14:16:50, Shezan Baig (Bloomberg) wrote: > Hey Scott, can you take a look ...
7 years, 3 months ago (2013-09-04 15:48:52 UTC) #9
ericvw
On 2013/09/04 15:48:52, scottmg wrote: > On 2013/09/04 14:16:50, Shezan Baig (Bloomberg) wrote: > > ...
7 years, 3 months ago (2013-09-04 16:16:12 UTC) #10
scottmg
On 2013/09/04 16:16:12, ericvw wrote: > On 2013/09/04 15:48:52, scottmg wrote: > > On 2013/09/04 ...
7 years, 3 months ago (2013-09-04 16:55:56 UTC) #11
ericvw
removed ez_setup.py as requested
7 years, 3 months ago (2013-09-04 17:43:38 UTC) #12
ericvw
Patchset should be complete based on feedback and the description of the change has been ...
7 years, 3 months ago (2013-09-04 17:47:56 UTC) #13
Shezan Baig (Bloomberg)
Hmm, I just committed it using "git cl dcommit", and dcommit seemed to get stuck ...
7 years, 3 months ago (2013-09-04 18:00:18 UTC) #14
scottmg
On 2013/09/04 18:00:18, Shezan Baig (Bloomberg) wrote: > Hmm, I just committed it using "git ...
7 years, 3 months ago (2013-09-05 19:14:50 UTC) #15
ericvw
7 years, 3 months ago (2013-09-19 17:33:14 UTC) #16
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698