Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 22816007: Measure usage for Node API removed from DOM4 (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Measure usage for Node API removed from DOM4 Measure usage for the following Node API that was removed from DOM4: - isSupported() - namespaceURI - prefix - isSameNode() This will help us determine if we can deprecate this API or we it should be reintroduced in DOM4. Specification: http://dom.spec.whatwg.org/#node R=arv BUG=272149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156037

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop localName from the CL #

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Source/core/dom/Node.idl View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-13 13:44:13 UTC) #1
arv (Not doing code reviews)
I would remove localNode from this CL. The other ones are non controversial. https://codereview.chromium.org/22816007/diff/1/Source/core/dom/Node.idl File ...
7 years, 4 months ago (2013-08-13 13:47:33 UTC) #2
do-not-use
https://codereview.chromium.org/22816007/diff/1/Source/core/dom/Node.idl File Source/core/dom/Node.idl (right): https://codereview.chromium.org/22816007/diff/1/Source/core/dom/Node.idl#newcode69 Source/core/dom/Node.idl:69: [TreatReturnedNullStringAs=Null, PerWorldBindings, MeasureAs=NodeLocalName] readonly attribute DOMString localName; // Removed ...
7 years, 4 months ago (2013-08-13 13:54:54 UTC) #3
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-13 14:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22816007/11001
7 years, 4 months ago (2013-08-13 17:05:40 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 18:13:52 UTC) #6
Message was sent while issue was closed.
Change committed as 156037

Powered by Google App Engine
This is Rietveld 408576698