Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 22816005: Add homogeneous point mapping to Matrix (Closed)

Created:
7 years, 4 months ago by egdaniel
Modified:
7 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add homogeneous point mapping to Matrix Adds mapping of homogeneous points (points with three scalar components, where the last component is not 1). Includes fix for tests when running on 32 bit debug builds BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=10755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -1 line) Patch
M include/core/SkMatrix.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +37 lines, -1 line 0 comments Download
M tests/MatrixTest.cpp View 2 chunks +139 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
In the previous version, its was the ubuntu and chrome x86 debug tests that failed. ...
7 years, 4 months ago (2013-08-14 14:32:57 UTC) #1
bsalomon
lgtm
7 years, 4 months ago (2013-08-14 14:36:21 UTC) #2
egdaniel
7 years, 4 months ago (2013-08-15 21:12:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698