Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: services/ui/ws/mus_gpu_memory_buffer_manager.h

Issue 2281583003: services/ui: Split GpuServiceInternal into gpu vs. ws pieces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DONE_2016.08.24_mus-ws-gpu-refactor
Patch Set: tot merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/mus_gpu_memory_buffer_manager.h
diff --git a/services/ui/gpu/mus_gpu_memory_buffer_manager.h b/services/ui/ws/mus_gpu_memory_buffer_manager.h
similarity index 88%
rename from services/ui/gpu/mus_gpu_memory_buffer_manager.h
rename to services/ui/ws/mus_gpu_memory_buffer_manager.h
index 1394ddf5abbc84a7c9b51b323c3e529eddcea17c..8e65b87b50cc44a3ee2ab6d138a5e52a1eec9786 100644
--- a/services/ui/gpu/mus_gpu_memory_buffer_manager.h
+++ b/services/ui/ws/mus_gpu_memory_buffer_manager.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SERVICES_UI_GPU_MUS_GPU_MEMORY_BUFFER_MANAGER_H_
-#define SERVICES_UI_GPU_MUS_GPU_MEMORY_BUFFER_MANAGER_H_
+#ifndef SERVICES_UI_WS_MUS_GPU_MEMORY_BUFFER_MANAGER_H_
+#define SERVICES_UI_WS_MUS_GPU_MEMORY_BUFFER_MANAGER_H_
#include <memory>
@@ -15,6 +15,8 @@ namespace ui {
class GpuServiceInternal;
+namespace ws {
+
// This GpuMemoryBufferManager is for establishing a GpuChannelHost used by
// mus locally.
class MusGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager {
Fady Samuel 2016/08/26 16:27:59 Optional bikeshed color: remove the word Mus here?
sadrul 2016/08/26 17:23:50 I plan to refactor+share this with the chrome code
@@ -22,8 +24,6 @@ class MusGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager {
MusGpuMemoryBufferManager(GpuServiceInternal* gpu_service, int client_id);
~MusGpuMemoryBufferManager() override;
- static MusGpuMemoryBufferManager* current();
-
// Overridden from gpu::GpuMemoryBufferManager:
std::unique_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(
const gfx::Size& size,
@@ -52,6 +52,7 @@ class MusGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager {
base::WeakPtrFactory<MusGpuMemoryBufferManager> weak_factory_;
};
+} // namespace ws
} // namespace ui
-#endif // SERVICES_UI_GPU_MUS_GPU_MEMORY_BUFFER_MANAGER_H_
+#endif // SERVICES_UI_WS_MUS_GPU_MEMORY_BUFFER_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698