build/config/sanitizers/BUILD.gn - Issue 2281583002: Revert of On asan/win bots building with goma, don't accidentally emit DWARF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2281583002: Revert of On asan/win bots building with goma, don't accidentally emit DWARF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/sanitizers/BUILD.gn

diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn

index 3768cb93553872974ffcf685544b21f43525efc9..cf51896225d1dfae31600dc8a573a057b773a17b 100644

--- a/build/config/sanitizers/BUILD.gn

+++ b/build/config/sanitizers/BUILD.gn

@@ -231,12 +231,6 @@

if (using_sanitizer) {

assert(is_clang, "sanitizers only supported with clang")

cflags += [ "-gline-tables-only" ]

- if (is_win) {

- # Just -gline-tables-only currently causes clang-cl to emit debug info

- # in DWARF format.

- # TODO(thakis): Remove this once we have a clang at LLVM r278139+

- cflags += [ "/Z7" ]

- }

}

# Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer,

« no previous file with comments | « no previous file | no next file » | no next file with comments »