Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2281583002: Revert of On asan/win bots building with goma, don't accidentally emit DWARF (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of On asan/win bots building with goma, don't accidentally emit DWARF (patchset #1 id:1 of https://codereview.chromium.org/2224073003/ ) Reason for revert: We have now rolled past r278139 and this shouldn't be necessary any more. Original issue's description: > On asan/win bots building with goma, don't accidentally emit DWARF > > This happens to work around a bug we don't yet understand, but seems > like a good change in its own right too. > > BUG=635715 > R=rnk@chromium.org > > Committed: https://crrev.com/314120a8cfd5df331d825566d25db1ba1a1983fe > Cr-Commit-Position: refs/heads/master@{#410785} TBR=rnk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635715 Committed: https://crrev.com/ed9ae8359c2706c16ca4159f0f2f063aa2034e23 Cr-Commit-Position: refs/heads/master@{#414454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of On asan/win bots building with goma, don't accidentally emit DWARF
4 years, 3 months ago (2016-08-25 15:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281583002/1
4 years, 3 months ago (2016-08-25 15:28:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 16:36:00 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:38:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9ae8359c2706c16ca4159f0f2f063aa2034e23
Cr-Commit-Position: refs/heads/master@{#414454}

Powered by Google App Engine
This is Rietveld 408576698