Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: src/compiler/instruction-scheduler.h

Issue 2281523002: [turbofan] Instruction scheduler: keep ready nodes list sorted by latency. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/instruction-scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction-scheduler.h
diff --git a/src/compiler/instruction-scheduler.h b/src/compiler/instruction-scheduler.h
index 271aa0d0d7ae2109eb07c02399986607ddd3ff6a..29599ee6139787b48483930ac033bcdd8af0b831 100644
--- a/src/compiler/instruction-scheduler.h
+++ b/src/compiler/instruction-scheduler.h
@@ -101,9 +101,7 @@ class InstructionScheduler final : public ZoneObject {
nodes_(scheduler->zone()) {
}
- void AddNode(ScheduleGraphNode* node) {
- nodes_.push_back(node);
- }
+ void AddNode(ScheduleGraphNode* node);
bool IsEmpty() const {
return nodes_.empty();
@@ -125,11 +123,6 @@ class InstructionScheduler final : public ZoneObject {
// Look for the best candidate to schedule, remove it from the queue and
// return it.
ScheduleGraphNode* PopBestCandidate(int cycle);
-
- private:
- // Compare the two nodes and return true if node1 is a better candidate than
- // node2 (i.e. node1 should be scheduled before node2).
- bool CompareNodes(ScheduleGraphNode *node1, ScheduleGraphNode *node2) const;
};
// A queue which pop a random node from the queue to perform stress tests on
« no previous file with comments | « no previous file | src/compiler/instruction-scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698