Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 22815023: gyp.el: use gyp-mode for .gclient files, too. (Closed)

Created:
7 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
7 years, 4 months ago
Reviewers:
tony
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

gyp.el: use gyp-mode for .gclient files, too. R=tony@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/emacs/gyp.el View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ami GONE FROM CHROMIUM
7 years, 4 months ago (2013-08-22 00:38:50 UTC) #1
tony
LGTM, but should it really be gyp mode? Seems like python mode would be more ...
7 years, 4 months ago (2013-08-22 00:42:25 UTC) #2
Ami GONE FROM CHROMIUM
7 years, 4 months ago (2013-08-22 16:52:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698