Issue 22815016: Merge 217429 "Fix crash on signing out with exit warning bubble ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22815016: Merge 217429 "Fix crash on signing out with exit warning bubble ..." (Closed)

Created:
7 years, 4 months ago by xiyuan

Modified:
7 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

Merge 217429 "Fix crash on signing out with exit warning bubble ..." > Fix crash on signing out with exit warning bubble open. > > Make ExitWarningHandler really own its bubble widget so that the widget > will not be released before destructing ExitWarningHandler, which could > happen when shutting down ash while the bubble is visible. > > BUG=272368 > > Review URL: https://chromiumcodereview.appspot.com/23122003 TBR=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218537

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -16 lines)			Patch
M	ash/accelerators/accelerator_controller_unittest.cc	View	6 chunks	+22 lines, -8 lines	0 comments	Download
M	ash/accelerators/exit_warning_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/accelerators/exit_warning_handler.cc	View	4 chunks	+4 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r218537.