Add detailed performance histograms to Files.app. (Abandoned)

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * This variable is checked in SelectFileDialogExtensionBrowserTest.
  * @type {number}
  */
@@ skipping 192 matching lines @@
   };
 
   // Public statics.
 
   FileManager.ListType = {
     DETAIL: 'detail',
     THUMBNAIL: 'thumb'
   };
 
   FileManager.prototype.initPreferences_ = function(callback) {
-    var group = new AsyncUtil.Group();
+   metrics.startInterval('Load.Preferences');
+   var group = new AsyncUtil.Group();

[hirono, 2013/08/12 16:53:51]

One more space is needed to indent?

[mtomasz, 2013/08/13 01:49:29]

Done.

 
     // DRIVE preferences should be initialized before creating DirectoryModel
     // to rebuild the roots list.
     group.add(this.getPreferences_.bind(this));
 
     // Get startup preferences.
     this.viewOptions_ = {};
     group.add(function(done) {
       this.dialogType = this.params_.type || DialogType.FULL_PAGE;
       this.startupPrefName_ = 'file-manager-' + this.dialogType;
@@ skipping 19 matching lines @@
           'file-manager-show-checkboxes', function(flag) {
         this.showCheckboxes_ = flag;
         done();
       }.bind(this));
     }.bind(this));
 
     // Removes the user data which is no longer used.
     // TODO(yoshiki): Remove this in M31 http://crbug.com/268784/
     chrome.storage.local.remove('folder-shortcuts-list');
 
-    group.run(callback);
+    group.run(function() {
+      metrics.recordInterval('Load.Preferences');
+      callback();
+    });
   };
 
   /**
    * Request local file system, resolve roots and init_ after that.
    * Warning, you can't use DOM nor any external scripts here, since it may not
    * be loaded yet. Functions in util.* and metrics.* are available and can
    * be used.
    *
    * @param {function()} callback Completion callback.
    * @private
@@ skipping 13 matching lines @@
       this.volumeManager_.mountDrive(function() {}, function() {});
   };
 
   /**
    * One time initialization for the file system and related things.
    *
    * @param {function()} callback Completion callback.
    * @private
    */
   FileManager.prototype.initFileSystemUI_ = function(callback) {
+    metrics.startInterval('Load.FileSystemUI');
     this.table_.startBatchUpdates();
     this.grid_.startBatchUpdates();
 
     this.initFileList_();
     this.setupCurrentDirectory_(true /* page loading */);
 
     // PyAuto tests monitor this state by polling this variable
     this.__defineGetter__('workerInitialized_', function() {
        return this.metadataCache_.isInitialized();
     }.bind(this));
@@ skipping 104 matching lines @@
     this.initContextMenus_();
     this.initCommands_();
 
     this.updateFileTypeFilter_();
 
     this.selectionHandler_.onFileSelectionChanged();
 
     this.table_.endBatchUpdates();
     this.grid_.endBatchUpdates();
 
+    metrics.recordInterval('Load.FileSystemUI');
     callback();
   };
 
   /**
    * @private
    */
   FileManager.prototype.initDateTimeFormatters_ = function() {
     var use12hourClock = !this.preferences_['use24hourClock'];
     this.table_.setDateTimeFormat(use12hourClock);
   };
@@ skipping 288 matching lines @@
   };
 
   /**
    * Initializes general purpose basic things, which are used by other
    * initializing methods.
    *
    * @param {function()} callback Completion callback.
    * @private
    */
   FileManager.prototype.initGeneral_ = function(callback) {
+    metrics.startInterval('Load.General');
     this.volumeManager_ = VolumeManager.getInstance();
     if (window.appState) {
       this.params_ = window.appState.params || {};
       this.defaultPath = window.appState.defaultPath;
     } else {
       this.params_ = location.search ?
                      JSON.parse(decodeURIComponent(location.search.substr(1))) :
                      {};
       this.defaultPath = this.params_.defaultPath;
     }
+    metrics.recordInterval('Load.General');
     callback();
   };
 
   /**
    * One time initialization of strings (mostly i18n).
    *
    * @param {function()} callback Completion callback.
    * @private
    */
   FileManager.prototype.initStrings_ = function(callback) {
+    metrics.startInterval('Load.Strings');
     // Fetch the strings via the private api if running in the browser window.
     // Otherwise, read cached strings from the local storage.
     if (util.platform.runningInBrowser()) {
       chrome.fileBrowserPrivate.getStrings(function(strings) {
         loadTimeData.data = strings;
+        metrics.recordInterval('Load.Strings');
         callback();
       });
     } else {
       chrome.storage.local.get('strings', function(items) {
         loadTimeData.data = items['strings'];
+        metrics.recordInterval('Load.Strings');
         callback();
       });
     }
   };
 
   /**
    * One time initialization of the Files.app's essential UI elements. These
    * elements will be shown to the user. Only visible elements should be
    * initialized here. Any heavy operation should be avoided. Files.app's
    * window is shown at the end of this routine.
    *
    * @param {function()} callback Completion callback.
    * @private
    */
   FileManager.prototype.initEssentialUI_ = function(callback) {
+    metrics.startInterval('Load.EssentialUI');
     this.listType_ = null;
 
     this.filesystemObserverId_ = null;
     this.driveObserverId_ = null;
 
     this.document_ = this.dialogDom_.ownerDocument;
     this.dialogType = this.params_.type || DialogType.FULL_PAGE;
     this.startupPrefName_ = 'file-manager-' + this.dialogType;
 
     // Used to filter out focusing by mouse.
@@ skipping 29 matching lines @@
 
     // Pre-populate the static localized strings.
     i18nTemplate.process(this.document_, loadTimeData);
 
     // Initialize the header.
     this.dialogDom_.querySelector('#app-name').innerText =
         chrome.runtime.getManifest().name;
 
     this.initDialogType_();
 
+    metrics.recordInterval('Load.Display');
+    metrics.recordInterval('Load.EssentialUI');
+
     // Show the window as soon as the UI pre-initialization is done.
     if (this.dialogType == DialogType.FULL_PAGE &&
         !util.platform.runningInBrowser()) {
       chrome.app.window.current().show();
       setTimeout(callback, 100);  // Wait until the animation is finished.
     } else {
-      callback();
+     callback();
     }
   };
 
   /**
    * One-time initialization of dialogs.
    * @private
    */
   FileManager.prototype.initDialogs_ = function() {
     var d = cr.ui.dialogs;
     d.BaseDialog.OK_LABEL = str('OK_LABEL');
     d.BaseDialog.CANCEL_LABEL = str('CANCEL_LABEL');
     this.error = new ErrorDialog(this.dialogDom_);
     this.alert = new d.AlertDialog(this.dialogDom_);
     this.confirm = new d.ConfirmDialog(this.dialogDom_);
     this.prompt = new d.PromptDialog(this.dialogDom_);
     this.shareDialog_ = new ShareDialog(this.dialogDom_);
     this.defaultTaskPicker =
         new cr.filebrowser.DefaultActionDialog(this.dialogDom_);
   };
 
   /**
    * One-time initialization of various DOM nodes. Loads the additional DOM
    * elements visible to the user. Initialize here elements, which are expensive
    * or hidden in the beginning.
    *
    * @param {function()} callback Completion callback.
    * @private
    */
   FileManager.prototype.initAdditionalUI_ = function(callback) {
+    metrics.startInterval('Load.AdditionalUI');
     this.initDialogs_();
 
     this.dialogDom_.addEventListener('drop', function(e) {
       // Prevent opening an URL by dropping it onto the page.
       e.preventDefault();
     });
 
     this.dialogDom_.addEventListener('click',
                                      this.onExternalLinkClick_.bind(this));
     // Cache nodes we'll be manipulating.
@@ skipping 176 matching lines @@
 
     util.addIsFocusedMethod();
 
     // Populate the static localized strings.
     i18nTemplate.process(this.document_, loadTimeData);
 
     // Arrange the file list.
     this.table_.normalizeColumns();
     this.table_.redraw();
 
+    metrics.recordInterval('Load.AdditionalUI');
     callback();
   };
 
   /**
    * @private
    */
   FileManager.prototype.onBreadcrumbClick_ = function(event) {
     this.directoryModel_.changeDirectory(event.path);
   };
 
@@ skipping 2819 matching lines @@
    */
   FileManager.prototype.setCtrlKeyPressed_ = function(flag) {
     this.ctrlKeyPressed_ = flag;
     // Before the DOM is constructed, the key event can be handled.
     var cacheClearCommand =
         this.document_.querySelector('#drive-clear-local-cache');
     if (cacheClearCommand)
       cacheClearCommand.canExecuteChange();
   };
 })();