Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2281473002: Revert of Updates the IME list when the IME has refreshed. (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
Reviewers:
James Cook, Azure Wei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, Shu Chen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ ) Reason for revert: ImeMenuTrayTest.RefreshImeWithListViewCreated is failing consistently on https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15622 Original issue's description: > Updates the IME list when the IME has refreshed. > > When the IME refreshes, we need to update the view of the list in IME menu. > Saves the created ImeListView and updates it when get IME refreshing event. > Add ImeMenuTrayTest.RefreshImeWithListViewCreated test. > > BUG=640432 > TEST=Verified on local build. > > Committed: https://crrev.com/c6f28a1effd401fd7e2e03707e0dd84f5346185b > Cr-Commit-Position: refs/heads/master@{#414329} TBR=jamescook@chromium.org,azurewei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640432 Committed: https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac Cr-Commit-Position: refs/heads/master@{#414388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -128 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 6 chunks +14 lines, -23 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc View 4 chunks +1 line, -87 lines 0 comments Download
M ash/test/test_system_tray_delegate.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ash/test/test_system_tray_delegate.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
johnme
Created Revert of Updates the IME list when the IME has refreshed.
4 years, 3 months ago (2016-08-25 10:59:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281473002/1
4 years, 3 months ago (2016-08-25 10:59:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:00:43 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:03:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7017855217bfc5d4ea11d44e526373bd7c571dac
Cr-Commit-Position: refs/heads/master@{#414388}

Powered by Google App Engine
This is Rietveld 408576698