Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2281463002: [Test] Fix CompilerDispatcher test. (Closed)

Created:
4 years, 3 months ago by rmcilroy
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Fix CompilerDispatcher test. Committed: https://crrev.com/b2734f6a1b7dff9ff90b049703f6aee3b0b45cc6 Cr-Commit-Position: refs/heads/master@{#38900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
Fixes an issue on win and mac 32bit where the stack check wasn't getting hit. ...
4 years, 3 months ago (2016-08-25 11:01:58 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-25 11:05:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281463002/1
4 years, 3 months ago (2016-08-25 11:24:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:29:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:29:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2734f6a1b7dff9ff90b049703f6aee3b0b45cc6
Cr-Commit-Position: refs/heads/master@{#38900}

Powered by Google App Engine
This is Rietveld 408576698