Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2281443003: Add marja to ast owners (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
adamk, Toon Verwaest
CC:
marja, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add marja to ast owners R=verwaest@chromium.org,adamk@chromium.org BUG= Committed: https://crrev.com/96886dc735800fb8989486f9107d4b857bf254c4 Cr-Commit-Position: refs/heads/master@{#38923}

Patch Set 1 #

Patch Set 2 : only marja #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
wdyt? We're all hacking on scopes / scopeinfo and not having to forward easy changes ...
4 years, 3 months ago (2016-08-25 12:47:44 UTC) #1
adamk
I'm happy to have Marja in owners (been meaning to propose that for a couple ...
4 years, 3 months ago (2016-08-25 15:37:55 UTC) #2
jochen (gone - plz use gerrit)
sure.. ptal
4 years, 3 months ago (2016-08-25 19:58:27 UTC) #4
adamk
lgtm
4 years, 3 months ago (2016-08-25 23:17:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281443003/20001
4 years, 3 months ago (2016-08-26 05:08:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 05:30:08 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 05:30:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96886dc735800fb8989486f9107d4b857bf254c4
Cr-Commit-Position: refs/heads/master@{#38923}

Powered by Google App Engine
This is Rietveld 408576698