Separate DuplicateFinder from Scanner.

Separate DuplicateFinder from Scanner.

DuplicateFinder isn't actually used by the Scanner, except for one
convenience function which we should probably remove, also.

BUG=

Committed: https://crrev.com/5b9b44d1f638f7d0bce0051a9d9e3fb1059e8558
Cr-Commit-Position: refs/heads/master@{#38904}

[vogelheim, 2016-08-25 08:52:45]

vogelheim@chromium.org changed reviewers:
+ marja@chromium.org

[vogelheim, 2016-08-25 08:52:46]

ptal

https://codereview.chromium.org/2281443002/diff/1/src/collector.h
File src/collector.h (right):

https://codereview.chromium.org/2281443002/diff/1/src/collector.h#newcode9
src/collector.h:9: #include "src/list-inl.h"
This is used for calling chunks_.Rewind(0) in member Reset(), line 117.

[marja, 2016-08-25 09:39:01]

lgtm, cool!

[vogelheim, 2016-08-25 10:50:43]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2016-08-25 10:50:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 10:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 10:52:01]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11584)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/11524)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7645)

[vogelheim, 2016-08-25 11:11:48]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 11:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:15:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11589)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[vogelheim, 2016-08-25 11:22:31]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 11:22:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:54:22]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-08-25 11:55:49]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-08-25 11:55:49]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2281443002/#ps60001
(title: "Fix rebase.")

[commit-bot: I haz the power, 2016-08-25 11:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:58:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-25 11:58:25]

Description was changed from

==========
Separate DuplicateFinder from Scanner.

DuplicateFinder isn't actually used by the Scanner, except for one
convenience function which we should probably remove, also.

BUG=
==========

to

==========
Separate DuplicateFinder from Scanner.

DuplicateFinder isn't actually used by the Scanner, except for one
convenience function which we should probably remove, also.

BUG=

Committed: https://crrev.com/5b9b44d1f638f7d0bce0051a9d9e3fb1059e8558
Cr-Commit-Position: refs/heads/master@{#38904}
==========

[commit-bot: I haz the power, 2016-08-25 11:58:26]

Patchset 4 (id:??) landed as
https://crrev.com/5b9b44d1f638f7d0bce0051a9d9e3fb1059e8558
Cr-Commit-Position: refs/heads/master@{#38904}