Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2281393002: Parameters are always context-allocated if accessible, so drop additional parameter lookup (Closed)

Created:
4 years, 3 months ago by Toon Verwaest
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parameters are always context-allocated if accessible, so drop additional parameter lookup BUG=v8:5209 Committed: https://crrev.com/5127dc055a0990139369400a6b21152744cb7d30 Cr-Commit-Position: refs/heads/master@{#38959}

Patch Set 1 #

Patch Set 2 : Also kill names_seen from DeserializeScopeInfo which was only there for parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M src/ast/scopes.cc View 1 4 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-27 08:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281393002/20001
4 years, 3 months ago (2016-08-27 08:16:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-27 08:38:07 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 08:38:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5127dc055a0990139369400a6b21152744cb7d30
Cr-Commit-Position: refs/heads/master@{#38959}

Powered by Google App Engine
This is Rietveld 408576698