third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-append.html - Issue 2281343002: [css-tables] Mark sibling cells dirty when a cell is added

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-append.html

Issue 2281343002: [css-tables] Mark sibling cells dirty when a cell is added (Closed)

Patch Set: respond to comments; fix test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/add-cell-with-large-border-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-cell-append-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Calculating collapsed borders for big tables is expensive, so we cache them and recalculate when needed.	2 Calculating collapsed borders for big tables is expensive, so we cache them and recalculate when needed.

3 Here we append new cell, expect that cache is invalidated and paint produces exp ected image.	3 Here we append new cell, expect that cache is invalidated and paint produces exp ected image.

4 -->	4 -->

5 <html>	5 <html>

6 <head>	6 <head>

7 <title></title>	7 <title></title>

8 <link rel="stylesheet" href="resources/cached.css">	8 <link rel="stylesheet" href="resources/cached.css">

9 <script src="../../../fast/repaint/resources/text-based-repaint.js"></sc ript>	9 <script src="../../../fast/repaint/resources/text-based-repaint.js"></sc ript>

10 <script type="text/javascript">	10 <script type="text/javascript">

11 function repaintTest() {	11 function repaintTest() {

12 newCell = document.createElement("td");	12 newCell = document.createElement("td");

13 newCell.style.borderLeftWidth = "6px";	13 newCell.style.borderWidth = "6px";

14 newCell.style.borderLeftStyle = "solid";	14 newCell.style.borderStyle = "solid";

15 newCell.style.borderLeftColor = "yellow";	15 newCell.style.borderColor = "yellow";

16 document.getElementById("row").appendChild(newCell);	16 document.getElementById("row").appendChild(newCell);

17 }	17 }

18 </script>	18 </script>

19 </head>	19 </head>

20 <body onload="runRepaintAndPixelTest()">	20 <body onload="runRepaintAndPixelTest()">

21 <table style="border-collapse:collapse; border:2px solid blue">	21 <table style="border-collapse:collapse; border:2px solid blue">

22 <tr id="row">	22 <tr id="row">

23 <td style="border:4px solid lime"/>	23 <td style="border:4px solid lime"/>

24 </tr>	24 </tr>

25 </table>	25 </table>

26 </body>	26 </body>

27 </html>	27 </html>

28	28

OLD	NEW