third_party/WebKit/LayoutTests/fast/table/add-cell-with-large-border.html - Issue 2281343002: [css-tables] Mark sibling cells dirty when a cell is added

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/add-cell-with-large-border.html

Issue 2281343002: [css-tables] Mark sibling cells dirty when a cell is added (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/table/add-cell-with-large-border-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTableRow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 td {

	4 width: 50px;

	5 height: 50px;

	6 padding: 0px;

	7 background: lime;

	8 }

	9 </style>

	10 <script src="../../resources/check-layout.js"></script>

	11 <script src="../../resources/run-after-layout-and-paint.js"></script>

	12 <script type="text/javascript">

	13 function addMiddleCell() {

	14 var cellToAdd = document.createElement("td");
	mstensho (USE GERRIT) 2016/08/29 09:07:17 I'm pretty sure making DOM tree structure changes I'm pretty sure making DOM tree structure changes isn't necessary here. You could just put this TD in the markup with display:none, and then display:table-cell it here. But I'm fine either way. Just a comment. dgrogan 2016/08/31 21:42:18 Ah, thanks for the tip. Show quoted text On 2016/08/29 09:07:17, mstensho wrote: > I'm pretty sure making DOM tree structure changes isn't necessary here. You > could just put this TD in the markup with display:none, and then > display:table-cell it here. But I'm fine either way. Just a comment. Ah, thanks for the tip.
	15 cellToAdd.style.border = "18px solid lightblue";

	16 theRow.insertBefore(cellToAdd, rightCell);

	17 checkLayout("table");

	18 }

	19 runAfterLayoutAndPaint(addMiddleCell, true);

	20 </script>

	21 <p>Adding a middle cell with a large border should make the table expand to acco mmodate it. The outer two cells' widths should also take on half of the new larg e border's width.</p>

	22 <table style="border-collapse:collapse" data-expected-width=190>

	23 <tr id="theRow">

	24 <td style="border:4px solid black" data-expected-width=61></td>

	25 <td data-expected-width=59 id="rightCell"></td>

	26 </tr>

	27 </table>

OLD	NEW