LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt - Issue 228133002: Fix crash if utterance is garbage-collected before speech ends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt

Issue 228133002: Fix crash if utterance is garbage-collected before speech ends. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash.html ('k') | Source/modules/speech/SpeechSynthesis.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt

diff --git a/LayoutTests/accessibility/aria-help-expected.txt b/LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt

similarity index 55%

copy from LayoutTests/accessibility/aria-help-expected.txt

copy to LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt

index 16c83066528ca32eb8fdf4d053cd372b21d752d1..5a8be225949e5c07e55056e0525c545c688e9c7d 100644

--- a/LayoutTests/accessibility/aria-help-expected.txt

+++ b/LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash-expected.txt

@@ -1,10 +1,8 @@

-button

-This tests that aria-help attribute works as expected.

+This tests that there isn't a crash if the utterance object is garbage-collected before speaking finishes.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

-PASS button.helpText is 'AXHelp: click here'

PASS successfullyParsed is true

TEST COMPLETE