Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2281313002: aw: Generalize destroy runnable hasRun (Closed)

Created:
4 years, 3 months ago by boliu
Modified:
4 years, 3 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Generalize destroy runnable hasRun Make it a general feature of CleanupReference. Committed: https://crrev.com/ddc9ab44e17d08d4ee6bca1c007402741ccb1f9f Cr-Commit-Position: refs/heads/master@{#415323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 5 chunks +3 lines, -13 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/CleanupReference.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal this CL depends on https://codereview.chromium.org/2282183002/
4 years, 3 months ago (2016-08-30 14:51:27 UTC) #2
Tobias Sargeant
On 2016/08/30 14:51:27, boliu wrote: > ptal > > this CL depends on https://codereview.chromium.org/2282183002/ LGTM.
4 years, 3 months ago (2016-08-30 14:57:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281313002/1
4 years, 3 months ago (2016-08-30 16:16:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 16:53:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:58:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddc9ab44e17d08d4ee6bca1c007402741ccb1f9f
Cr-Commit-Position: refs/heads/master@{#415323}

Powered by Google App Engine
This is Rietveld 408576698