Use AuthorizedInstall to move Chrome into place and set up permissions

chrome/installer/mac/app/Unpacker.m

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "Unpacker.h"
 
 #import <AppKit/AppKit.h>
 #include <DiskArbitration/DiskArbitration.h>
 #include <dispatch/dispatch.h>
 #include <Security/Security.h>

[Mark Mentovai, 2016/08/29 18:51:25]

Move this #include to the other file.

[Anna Zeng, 2016/08/29 21:47:05]

Done.

 
 #import "Downloader.h"
 
 @interface Unpacker () {
   NSURL* temporaryDirectoryURL_;
   NSString* mountPath_;
 
   NSTask* __weak mountTask_;
 
   DASessionRef session_;
   dispatch_queue_t unpack_dq_;
 }
 - (void)didFinishEjectingDisk:(DADiskRef)disk
                 withDissenter:(DADissenterRef)dissenter;
 @end
 
 static void eject_callback(DADiskRef disk,
                            DADissenterRef dissenter,
                            void* context) {
-  Unpacker* unpacker = (__bridge Unpacker*)context;
+  Unpacker* unpacker = (__bridge_transfer Unpacker*)context;
   [unpacker didFinishEjectingDisk:disk withDissenter:dissenter];
 }
 
 static void unmount_callback(DADiskRef disk,
                              DADissenterRef dissenter,
                              void* context) {
   if (dissenter) {
     Unpacker* unpacker = (__bridge Unpacker*)context;
     [unpacker didFinishEjectingDisk:disk withDissenter:dissenter];
   } else {
@@ skipping 49 matching lines @@
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(cleanUp)
              name:NSApplicationWillTerminateNotification
            object:nil];
 
   [[NSFileManager defaultManager] moveItemAtURL:fileURL
                                           toURL:temporaryDiskImageURL
                                           error:nil];
 
-  SecStaticCodeRef diskStaticCode;
-  SecRequirementRef diskRequirement;
-  SecStaticCodeCreateWithPath((CFURLRef)CFBridgingRetain(temporaryDiskImageURL),
-                              kSecCSDefaultFlags, &diskStaticCode);
-  // TODO: what requirement goes in here??
-  SecRequirementCreateWithString((CFStringRef) @"", kSecCSDefaultFlags,
-                                 &diskRequirement);
-  if (SecStaticCodeCheckValidity(diskStaticCode, kSecCSDefaultFlags,
-                                 diskRequirement) != errSecSuccess) {
-    // TODO: add in more strict error handling
-    NSLog(@"verification failed");
-  }
-
   NSString* path = @"/usr/bin/hdiutil";
   NSArray* args = @[
     @"attach", temporaryDiskImageURL, @"-nobrowse", @"-noverify",
     @"-mountpoint", mountPath_
   ];
 
   NSTask* mountTask = [[NSTask alloc] init];
   mountTask.launchPath = path;
   mountTask.arguments = args;
   mountTask.terminationHandler = ^void(NSTask* task) {
@@ skipping 20 matching lines @@
   unpack_dq_ =
       dispatch_queue_create("com.google.chrome.unpack", DISPATCH_QUEUE_SERIAL);
   DASessionSetDispatchQueue(session_, unpack_dq_);
   DADiskRef child_disk = DADiskCreateFromVolumePath(
       nil, session_,
       (__bridge CFURLRef)[NSURL fileURLWithPath:mountPath_ isDirectory:YES]);
   DADiskRef whole_disk = DADiskCopyWholeDisk(child_disk);
 
   DADiskUnmount(whole_disk,
                 kDADiskUnmountOptionWhole | kDADiskUnmountOptionForce,
-                unmount_callback, (__bridge void*)self);
+                unmount_callback, (__bridge_retained void*)self);
 
   CFRelease(whole_disk);
   CFRelease(child_disk);
 }
 
 - (void)didFinishEjectingDisk:(DADiskRef)disk
                 withDissenter:(DADissenterRef)dissenter {
   DASessionSetDispatchQueue(session_, NULL);
   dispatch_release(unpack_dq_);
   CFRelease(session_);
   NSError* error = nil;
   if (dissenter) {
     DAReturn status = DADissenterGetStatus(dissenter);
     error = [NSError
         errorWithDomain:@"ChromeErrorDomain"
                    code:err_get_code(status)
                userInfo:@{
                  NSLocalizedDescriptionKey :
                      (__bridge NSString*)DADissenterGetStatusString(dissenter)
                }];
     [delegate_ unpacker:self onUnmountFailure:error];
   } else {
     [self cleanUp];
     [delegate_ unpacker:self onUnmountSuccess:mountPath_];
   }
 }
 
 @end