runtime/vm/isolate.cc - Issue 2281263002: AOT: Reassign class ids so class hierarchies have contiguous ranges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 2281263002: AOT: Reassign class ids so class hierarchies have contiguous ranges. (Closed)

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index 3c6c88b8049299086efe71ec19e2c6e858493fbd..c9cabbc387b01f87573f250e058cb1e2761c0d0e 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1895,7 +1895,8 @@ RawClass* Isolate::GetClassForHeapWalkAt(intptr_t cid) {

raw_class = class_table()->At(cid);

#endif // !PRODUCT

ASSERT(raw_class != NULL);

- ASSERT(raw_class->ptr()->id_ == cid);

+ // This is temporarily untrue during a class id remap.

+ // ASSERT(raw_class->ptr()->id_ == cid);

return raw_class;

}