AOT: Reassign class ids so class hierarchies have contiguous ranges.

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
 #include "platform/text_buffer.h"
@@ skipping 1877 matching lines @@
 #ifndef PRODUCT
   if (IsReloading()) {
     raw_class = reload_context()->GetClassForHeapWalkAt(cid);
   } else {
     raw_class = class_table()->At(cid);
   }
 #else
   raw_class = class_table()->At(cid);
 #endif  // !PRODUCT
   ASSERT(raw_class != NULL);
-  ASSERT(raw_class->ptr()->id_ == cid);
+  // This is temporarily untrue during a class id remap.
+  // ASSERT(raw_class->ptr()->id_ == cid);

[siva, 2016/08/30 23:12:40]

remap only happens in DART_PRECOMPILER, should this be

#if !defined(DART_PRECOMPILER)
  ASSERT(raw_class_ptr()->id_ == cid);
#endif

   return raw_class;
 }
 
 
 #ifndef PRODUCT
 static const char* ExceptionPauseInfoToServiceEnum(Dart_ExceptionPauseInfo pi) {
   switch (pi) {
     case kPauseOnAllExceptions:
       return "All";
     case kNoPauseOnExceptions:
@@ skipping 991 matching lines @@
 void IsolateSpawnState::DecrementSpawnCount() {
   ASSERT(spawn_count_monitor_ != NULL);
   ASSERT(spawn_count_ != NULL);
   MonitorLocker ml(spawn_count_monitor_);
   ASSERT(*spawn_count_ > 0);
   *spawn_count_ = *spawn_count_ - 1;
   ml.Notify();
 }
 
 }  // namespace dart