Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2281253002: Fix code to avoid launching Swiftshader if it's crashed too often. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix code to avoid launching Swiftshader if it's crashed too often. It's possible hardware_gpu_enabled_ is true (because the GPU is blacklisted and hasn't crashed at all) even when using Swiftshader. In this case, the code incorrectly tried to launch the GPU process even if it had already crashed too much. Committed: https://crrev.com/2caa8dadc70d645af91b46c503f82cf2e87c46a1 Cr-Commit-Position: refs/heads/master@{#415175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jbauman
4 years, 3 months ago (2016-08-29 20:51:41 UTC) #5
piman
lgtm
4 years, 3 months ago (2016-08-29 21:01:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281253002/1
4 years, 3 months ago (2016-08-29 21:51:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:45:02 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:47:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2caa8dadc70d645af91b46c503f82cf2e87c46a1
Cr-Commit-Position: refs/heads/master@{#415175}

Powered by Google App Engine
This is Rietveld 408576698