Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2281243002: Dead-on-arrival GPU processes should have non-zero exit code. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dead-on-arrival GPU processes should have non-zero exit code. This way GpuProcessHost::RecordProcessCrash will be called, allowing Chrome to fall back to SwiftShader or just give up on launching the GPU after a little while. Committed: https://crrev.com/b4bb06f17e681e6ec430da374659908612b5bcdd Cr-Commit-Position: refs/heads/master@{#415159}

Patch Set 1 #

Patch Set 2 : change exit code to 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/gpu/gpu_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
jbauman
4 years, 3 months ago (2016-08-29 20:32:04 UTC) #10
piman
LGTM
4 years, 3 months ago (2016-08-29 20:57:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281243002/20001
4 years, 3 months ago (2016-08-29 21:51:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:31:07 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:33:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4bb06f17e681e6ec430da374659908612b5bcdd
Cr-Commit-Position: refs/heads/master@{#415159}

Powered by Google App Engine
This is Rietveld 408576698