Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2281223002: [fuchsia] Some directory operations (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -14 lines) Patch
M runtime/bin/directory_fuchsia.cc View 1 chunk +63 lines, -12 lines 0 comments Download
M runtime/bin/directory_test.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M runtime/bin/run_vm_tests_fuchsia.cc View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
zra
The added functions are copied from Android.
4 years, 3 months ago (2016-08-26 20:05:54 UTC) #2
Florian Schneider
Lgtm https://codereview.chromium.org/2281223002/diff/1/runtime/bin/run_vm_tests_fuchsia.cc File runtime/bin/run_vm_tests_fuchsia.cc (right): https://codereview.chromium.org/2281223002/diff/1/runtime/bin/run_vm_tests_fuchsia.cc#newcode109 runtime/bin/run_vm_tests_fuchsia.cc:109: "DirectoryCreateDelete", Shouldn't this be just DirectoryDelete?
4 years, 3 months ago (2016-08-26 20:34:04 UTC) #3
zra
https://codereview.chromium.org/2281223002/diff/1/runtime/bin/run_vm_tests_fuchsia.cc File runtime/bin/run_vm_tests_fuchsia.cc (right): https://codereview.chromium.org/2281223002/diff/1/runtime/bin/run_vm_tests_fuchsia.cc#newcode109 runtime/bin/run_vm_tests_fuchsia.cc:109: "DirectoryCreateDelete", On 2016/08/26 20:34:04, Florian Schneider wrote: > Shouldn't ...
4 years, 3 months ago (2016-08-26 21:29:36 UTC) #4
zra
4 years, 3 months ago (2016-08-26 21:30:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4a69e922d9527ffde6604baf77bf10948504198 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698