Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 22812003: Make android_run_skia exit with the correct code (Closed)

Created:
7 years, 4 months ago by borenet
Modified:
7 years, 4 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make android_run_skia exit with the correct code R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M platform_tools/android/bin/android_run_skia View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
The unit tests failed on this run: http://108.170.217.252:10115/builders/Test-Android-Xoom-Tegra2-Arm7-Release/builds/738/steps/RunTests/logs/stdio but the buildbot thinks they passed, because ...
7 years, 4 months ago (2013-08-12 16:23:08 UTC) #1
djsollen
lgtm
7 years, 4 months ago (2013-08-12 16:36:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/22812003/1
7 years, 4 months ago (2013-08-12 16:55:26 UTC) #3
borenet
7 years, 4 months ago (2013-08-12 17:21:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r10684.

Powered by Google App Engine
This is Rietveld 408576698