Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2281163002: GN: support compiler_prefix, use it for ccache on bots. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: support compiler_prefix, use it for ccache on bots. This makes it considerably easier to use ccache with the Android NDK. You can now just set compiler_prefix = "ccache" ndk = "/path/to/ndk" and we'll use the NDK clang, wrapped with ccache. The name compiler_prefix is stolen from / compatible with Chrome. If you have ccache, you can just always leave compiler_prefix="ccache" enabled. This should make it an unusual thing for humans to have to change cc or cxx. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281163002 Committed: https://skia.googlesource.com/skia/+/cab0bb7fc694a59de379befb6062f48fdd1b731c

Patch Set 1 #

Messages

Total messages: 14 (10 generated)
mtklein_C
4 years, 3 months ago (2016-08-26 19:10:02 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-08-26 19:14:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281163002/1
4 years, 3 months ago (2016-08-26 20:42:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:43:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cab0bb7fc694a59de379befb6062f48fdd1b731c

Powered by Google App Engine
This is Rietveld 408576698