Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2281153002: [layoutng] async layout part 1: Change the API to support async (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] async layout part 1: Change the API to support async The implementation is not async yet. I will add the state machine in a second CL. R=ikilpatrick@chromium.org,eae@chromium.org BUG=635619 Committed: https://crrev.com/45ad03d295dd8f8885465f10d5f1d0a3d55bfb76 Cr-Commit-Position: refs/heads/master@{#414799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
cbiesinger
4 years, 3 months ago (2016-08-26 18:57:48 UTC) #1
eae
LGTM
4 years, 3 months ago (2016-08-26 19:07:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281153002/1
4 years, 3 months ago (2016-08-26 19:10:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 20:30:51 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:32:53 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/45ad03d295dd8f8885465f10d5f1d0a3d55bfb76
Cr-Commit-Position: refs/heads/master@{#414799}

Powered by Google App Engine
This is Rietveld 408576698