Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2281103002: Add test for forwarding the load event while pending deletion. (Closed)

Created:
4 years, 3 months ago by alexmos
Modified:
4 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for forwarding the load event while pending deletion. BUG=636513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7e03e5a9496c7026f614d868361a64cc25c80f45 Cr-Commit-Position: refs/heads/master@{#415388}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
alexmos
Charlie, can you please take a look when you get back? No rush on this; ...
4 years, 3 months ago (2016-08-26 21:01:40 UTC) #11
Charlie Reis
Thanks for following up! LGTM. (Let's be sure to audit the other places that might ...
4 years, 3 months ago (2016-08-30 17:28:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281103002/20001
4 years, 3 months ago (2016-08-30 17:29:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 19:18:31 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:20:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e03e5a9496c7026f614d868361a64cc25c80f45
Cr-Commit-Position: refs/heads/master@{#415388}

Powered by Google App Engine
This is Rietveld 408576698