Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2281083002: Revert "Remove the document tagged code as it is unused." (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Remove the document tagged code as it is unused." The code that was deleted is being used by Android foxit viewer This reverts commit dbfc3522a6ee24d17f2c50a5dcc465db52a280ee and updates the #includes Committed: https://pdfium.googlesource.com/pdfium/+/0c2d0a5c5b4ee3c1815df17c0e9c4f5880c1e7ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+665 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A core/fpdfdoc/doc_tagged.cpp View 1 chunk +459 lines, -0 lines 0 comments Download
A core/fpdfdoc/include/fpdf_tagged.h View 1 chunk +93 lines, -0 lines 0 comments Download
A core/fpdfdoc/tagged_int.h View 1 chunk +107 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
npm
PTAL
4 years, 3 months ago (2016-08-26 17:36:01 UTC) #5
Lei Zhang
If this is just straight up putting the code back, then lgtm. Don't bother changing ...
4 years, 3 months ago (2016-08-26 18:19:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281083002/1
4 years, 3 months ago (2016-08-26 18:31:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/0c2d0a5c5b4ee3c1815df17c0e9c4f5880c1e7ef
4 years, 3 months ago (2016-08-26 18:32:13 UTC) #12
dsinclair
On 2016/08/26 18:32:13, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 3 months ago (2016-08-29 13:29:12 UTC) #13
npm
4 years, 3 months ago (2016-08-29 13:58:04 UTC) #14
Message was sent while issue was closed.
On 2016/08/29 13:29:12, dsinclair wrote:
> On 2016/08/26 18:32:13, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://pdfium.googlesource.com/pdfium/+/0c2d0a5c5b4ee3c1815df17c0e9c4f5880c1...
> 
> 
> Is all of the code in these files required by the viewer or only some of it?
Can
> we split these files apart like the rest of the code in core/fpdfdoc and for
the
> stuff that is required, add API's into public/ so we can keep track of what's
> needed?

This is only a revert CL. pdfium:568 has been filed requesting public API. As
far as I can tell, the classes/structs declared at fpdf_tagged.h are being used,
but the ones at tagged_int.h are not. However, tagged_int.h is being imported
once (possibly for no good reason).

Powered by Google App Engine
This is Rietveld 408576698