Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: src/ast/scopes.h

Issue 2281073002: Create ScopeInfos while analyzing the Scope chain (Closed)
Patch Set: updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 8a84664c18ec44d657ebc85db9208c98d3b66c5f..ad53ee69c6bc120f64532403256f2cb64893f04d 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -384,10 +384,7 @@ class Scope: public ZoneObject {
// 'this' is bound, and what determines the function kind.
DeclarationScope* GetReceiverScope();
- // Creates a scope info if it doesn't already exist.
- Handle<ScopeInfo> GetScopeInfo(Isolate* isolate);
-
- // GetScopeInfo() must have been called once to create the ScopeInfo.
+ // Analyze() must have been called once to create the ScopeInfo.
Handle<ScopeInfo> scope_info() {
DCHECK(!scope_info_.is_null());
return scope_info_;
@@ -546,7 +543,7 @@ class Scope: public ZoneObject {
void AllocateNonParameterLocal(Variable* var);
void AllocateDeclaredGlobal(Variable* var);
void AllocateNonParameterLocalsAndDeclaredGlobals();
- void AllocateVariablesRecursively();
+ void AllocateVariablesRecursively(Isolate* isolate);
// Construct a scope based on the scope info.
Scope(Zone* zone, ScopeType type, Handle<ScopeInfo> scope_info);
« no previous file with comments | « src/ast/ast-numbering.cc ('k') | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698