Remove extensions_tests.gyp[i]

Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper "unit_tests" and "browser_tests" targets for the various subdirectories to keep the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this check pass.

Committed: https://crrev.com/dc1e618a885f0bf51b8fa6fa24d14329ea3d81ad
Cr-Commit-Position: refs/heads/master@{#415419}

[brettw, 2016-08-26 22:43:11]

Description was changed from

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the new targets to GN check and adds additional dependencies to make this
check pass
==========

to

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are
not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this
check pass.
==========

[brettw, 2016-08-26 22:43:11]

brettw@chromium.org changed reviewers:
+ asargent@chromium.org

[brettw, 2016-08-26 22:44:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:45:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:49:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[asargent_no_longer_on_chrome, 2016-08-26 23:44:26]

lgtm, but I should note that I haven't spent a lot of time understanding GN at a
deep level so I wouldn't be the right person to spot any subtle issues that
could arise here. I'll rely on your judgement as to whether there's anything
complicated that someone else more familiar with GN should have a look.

[brettw, 2016-08-29 17:00:21]

fixes

[brettw, 2016-08-29 17:00:22]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 17:07:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 17:20:09]

More fixes

[brettw, 2016-08-29 17:20:10]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-29 17:20:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps40001
(title: "More fixes")

[commit-bot: I haz the power, 2016-08-29 17:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 17:39:00]

extensions_shell_deps

[brettw, 2016-08-29 17:39:01]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-29 17:39:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps60001
(title: "extensions_shell_deps")

[commit-bot: I haz the power, 2016-08-29 17:50:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 18:05:37]

Keyed service on ChromeOS

[brettw, 2016-08-29 18:05:38]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-29 18:05:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps80001
(title: "Keyed service on ChromeOS")

[commit-bot: I haz the power, 2016-08-29 18:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 20:36:49]

merge

[brettw, 2016-08-29 20:36:51]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-29 20:36:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2016-08-29 21:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 21:29:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 21:51:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-29 22:27:21]

Fixes

[brettw, 2016-08-29 22:27:22]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-29 22:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps140001
(title: "Fixes")

[commit-bot: I haz the power, 2016-08-29 22:53:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:35:54]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brettw, 2016-08-30 17:19:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-08-30 17:19:34]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-08-30 17:19:38]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-30 17:19:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps160001
(title: "Remove shell_display_info_provider")

[commit-bot: I haz the power, 2016-08-30 17:19:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:38:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-30 19:25:20]

chromeos

[brettw, 2016-08-30 19:25:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-30 19:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2281053004/#ps180001
(title: "chromeos")

[commit-bot: I haz the power, 2016-08-30 19:26:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:52:38]

Description was changed from

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are
not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this
check pass.
==========

to

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are
not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this
check pass.
==========

[commit-bot: I haz the power, 2016-08-30 20:52:39]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-08-30 20:53:50]

Description was changed from

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are
not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this
check pass.
==========

to

==========
Remove extensions_tests.gyp[i]

Inlines sources into the GN build files. This creates smaller helper
"unit_tests" and "browser_tests" targets for the various subdirectories to keep
the file lists closer to the code.

Adds the wifi display unit tests which were missing from the GN build (these are
not compiled by default, only when you explicitly pass a flag).

Adds the new targets to GN check and adds additional dependencies to make this
check pass.

Committed: https://crrev.com/dc1e618a885f0bf51b8fa6fa24d14329ea3d81ad
Cr-Commit-Position: refs/heads/master@{#415419}
==========

[commit-bot: I haz the power, 2016-08-30 20:53:51]

Patchset 10 (id:??) landed as
https://crrev.com/dc1e618a885f0bf51b8fa6fa24d14329ea3d81ad
Cr-Commit-Position: refs/heads/master@{#415419}