SyncFS: Reorder initialization sequence of SyncFileSystemService

chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 91 matching lines @@
     SetResult(new base::FundamentalValue(false));
     SendResponse(false);
     return;
   }
 
   SetResult(new base::FundamentalValue(true));
   SendResponse(true);
 }
 
 bool SyncFileSystemRequestFileSystemFunction::RunImpl() {
+  // Initializes observer of sync events in SyncFileSystem.

[kinuko, 2013/08/29 08:28:21]

Can you elaborate a little more:
// SyncFileSystem initialization is done in OpenFileSystem below, but we call
GetSyncFileSystemService
// here too to initialize sync event observer for extensions API.

[nhiroki, 2013/08/29 08:43:35]

Done.

+  GetSyncFileSystemService(profile());
+
   // Initializes sync context for this extension and continue to open
   // a new file system.
-  GetSyncFileSystemService(profile())->
-      InitializeForApp(
-          GetFileSystemContext(),
-          source_url().GetOrigin(),
-          base::Bind(&self::DidInitializeFileSystemContext, this));
+  BrowserThread::PostTask(
+      BrowserThread::IO, FROM_HERE,
+      Bind(&fileapi::FileSystemContext::OpenFileSystem,
+           GetFileSystemContext(),
+           source_url().GetOrigin(),
+           fileapi::kFileSystemTypeSyncable,
+           fileapi::OPEN_FILE_SYSTEM_CREATE_IF_NONEXISTENT,
+           base::Bind(&self::DidOpenFileSystem, this)));
   return true;
 }
 
 fileapi::FileSystemContext*
 SyncFileSystemRequestFileSystemFunction::GetFileSystemContext() {
   DCHECK(render_view_host());
   return BrowserContext::GetStoragePartition(
       profile(),
       render_view_host()->GetSiteInstance())->GetFileSystemContext();
 }
 
-void SyncFileSystemRequestFileSystemFunction::DidInitializeFileSystemContext(
-    SyncStatusCode status) {
-  if (status != sync_file_system::SYNC_STATUS_OK) {
-    error_ = sync_file_system::SyncStatusCodeToString(status);
-    SendResponse(false);
-    return;
-  }
-
-  if (!render_view_host()) {
-    // The app seems to have been closed.
-    return;
-  }
-
-  BrowserThread::PostTask(
-      BrowserThread::IO, FROM_HERE,
-      Bind(&fileapi::FileSystemContext::OpenFileSystem,
-           GetFileSystemContext(),
-           source_url().GetOrigin(),
-           fileapi::kFileSystemTypeSyncable,
-           fileapi::OPEN_FILE_SYSTEM_CREATE_IF_NONEXISTENT,
-           base::Bind(&self::DidOpenFileSystem, this)));
-}
-
 void SyncFileSystemRequestFileSystemFunction::DidOpenFileSystem(
     base::PlatformFileError error,
     const std::string& file_system_name,
     const GURL& root_url) {
   // Repost to switch from IO thread to UI thread for SendResponse().
   if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         Bind(&SyncFileSystemRequestFileSystemFunction::DidOpenFileSystem,
@@ skipping 216 matching lines @@
   DCHECK(service);
   api::sync_file_system::ConflictResolutionPolicy policy =
       ConflictResolutionPolicyToExtensionEnum(
           service->GetConflictResolutionPolicy());
   SetResult(new base::StringValue(
           api::sync_file_system::ToString(policy)));
   return true;
 }
 
 }  // namespace extensions