Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2280943002: [heap] Properly propagate allocated space during new space evacuaton in MC (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Properly propagate allocated space during new space evacuaton in MC New space evaucation in MC supports, similar to scavenges, fall back allocation in old space. For new space evacuation we support stick and non-sticky modes for fallback. The sticky mode essentially removes the capability to allocate in new space while the non-sticky mode only falls back for a single allocation. We use the non-sticky mode for allocations that are too large for a LAB but should still go in new space. When such an allocation fails in new space, we allocate in old space in non-sticky mode as we would still like to reuse the remainder memory in new space. However, in such a case we fail to properly report the space allocated in resulting in a missed recorded slot. BUG=chromium:641270 R=ulan@chromium.org Committed: https://crrev.com/bb4974d1864502b99e2fd639b6c584031afd47cc Cr-Commit-Position: refs/heads/master@{#38940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/heap/mark-compact.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Lippautz
ptal as discussed: this is too fragile to test in the long run. manually verified ...
4 years, 3 months ago (2016-08-26 11:55:12 UTC) #3
ulan
LGTM, good catch!
4 years, 3 months ago (2016-08-26 11:55:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280943002/1
4 years, 3 months ago (2016-08-26 12:25:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 12:27:17 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 12:27:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb4974d1864502b99e2fd639b6c584031afd47cc
Cr-Commit-Position: refs/heads/master@{#38940}

Powered by Google App Engine
This is Rietveld 408576698