Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 228093002: Add treehash tool for win_toolchain (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add treehash tool for win_toolchain This matches what the python does in get_toolchain_if_necessary.py and produces the same SHA1. This allows the toolchain "up-to-date" check to be much faster (from ~1.1s -> ~0.1s on Z620). Since this is run in the hot path of GN generation we don't want it to be slow. See linked bug for timing details. This is intended to replace a bunch of code in the above python script but I'll do the integration as a separate change. R=brettw@chromium.org, dpranke@chromium.org BUG=360878

Patch Set 1 #

Patch Set 2 : tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -0 lines) Patch
A win_toolchain/treehash/m.bat View 1 chunk +2 lines, -0 lines 0 comments Download
A win_toolchain/treehash/treehash.cc View 1 1 chunk +337 lines, -0 lines 0 comments Download
A win_toolchain/treehash/treehash.exe View 1 Binary file 0 comments Download
A win_toolchain/treehash/treehash.py View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 8 months ago (2014-04-08 06:00:53 UTC) #1
Dirk Pranke
Why is this run during GN generation?
6 years, 8 months ago (2014-04-08 19:07:08 UTC) #2
scottmg
I have no idea! That'll teach me to write code late at night after sheriffing. ...
6 years, 8 months ago (2014-04-08 19:36:33 UTC) #3
scottmg
Closing in preference to https://codereview.chromium.org/226643011/.
6 years, 8 months ago (2014-04-08 20:01:04 UTC) #4
brettw
6 years, 8 months ago (2014-04-08 20:23:38 UTC) #5
Message was sent while issue was closed.
On 2014/04/08 19:07:08, Dirk Pranke wrote:
> Why is this run during GN generation?

I'm glad somebody is paying attention!

Powered by Google App Engine
This is Rietveld 408576698