Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2280923002: Reduce 'iterate self and instances' helper-count in SVGElement.cpp (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce 'iterate self and instances' helper-count in SVGElement.cpp Generalizing updateInstancesAnimatedAttribute{,NoInvalidate} to one higher-level helper to get rid of the subtle differences brought on by the differences in invalidation semantics. BUG=640676 Committed: https://crrev.com/abf9460b9549540ba98ae846e12b2fa91133d62e Cr-Commit-Position: refs/heads/master@{#414845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -29 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 4 chunks +21 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-08-26 12:39:45 UTC) #4
pdr.
LGTM
4 years, 3 months ago (2016-08-26 21:24:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280923002/1
4 years, 3 months ago (2016-08-26 21:27:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 22:53:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:55:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abf9460b9549540ba98ae846e12b2fa91133d62e
Cr-Commit-Position: refs/heads/master@{#414845}

Powered by Google App Engine
This is Rietveld 408576698