[libfuzzer] Update GN flags for reproducing bugs.

[libfuzzer] Update GN flags for reproducing bugs.

R=dalecurtis@chromium.org, inferno@chromium.org, ochang@chromium.org, thakis@chromium.org
BUG=640967
Committed: https://crrev.com/beaf9f5d23523b4c285e73836b38df68165f0f00
Cr-Commit-Position: refs/heads/master@{#414958}

[Nico, 2016-08-26 12:04:24]

lgtm, thanks!

[inferno, 2016-08-26 14:45:26]

https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
File testing/libfuzzer/reproducing.md (right):

https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
testing/libfuzzer/reproducing.md:54: $ gn gen out/afl '--args=use_afl=true
is_asan=true enable_nacl=false proprietary_codecs=true ffmpeg_branding="Chrome"'
Most devs will be using is_debug=false, so lets make it default for asan too.
and then fix your above comment.

Also, add point about ffmpeg_branding=ChromeOS for linux, ffmpeg_branding=Chrome
for other platforms.

[Oliver Chang, 2016-08-26 16:08:34]

On 2016/08/26 14:45:26, inferno wrote:
>
https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
> File testing/libfuzzer/reproducing.md (right):
> 
>
https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
> testing/libfuzzer/reproducing.md:54: $ gn gen out/afl '--args=use_afl=true
> is_asan=true enable_nacl=false proprietary_codecs=true
ffmpeg_branding="Chrome"'
> Most devs will be using is_debug=false, so lets make it default for asan too.
> and then fix your above comment.
> 
> Also, add point about ffmpeg_branding=ChromeOS for linux,
ffmpeg_branding=Chrome
> for other platforms.

lgtm. +1 to inferno's comment

[mmoroz, 2016-08-26 16:36:00]

Updated. PTAL :)

https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
File testing/libfuzzer/reproducing.md (right):

https://codereview.chromium.org/2280913002/diff/1/testing/libfuzzer/reproduci...
testing/libfuzzer/reproducing.md:54: $ gn gen out/afl '--args=use_afl=true
is_asan=true enable_nacl=false proprietary_codecs=true ffmpeg_branding="Chrome"'
On 2016/08/26 14:45:26, inferno wrote:
> Most devs will be using is_debug=false, so lets make it default for asan too.
> and then fix your above comment.
> 
> Also, add point about ffmpeg_branding=ChromeOS for linux,
ffmpeg_branding=Chrome
> for other platforms.

Done.

[inferno, 2016-08-26 17:41:01]

lgtm with nits.

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
File testing/libfuzzer/reproducing.md (right):

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
testing/libfuzzer/reproducing.md:49: For ASan builds both Debug and Release
configurations are supported.
add a comma after "For ASan builds"

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
testing/libfuzzer/reproducing.md:53: For other planforms
`ffmpeg_branding=Chrome`.
typo: planforms -> platforms.
s/For other planforms/For other platforms, use

[DaleCurtis, 2016-08-26 18:08:24]

lgtm

[mmoroz, 2016-08-28 08:27:07]

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
File testing/libfuzzer/reproducing.md (right):

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
testing/libfuzzer/reproducing.md:49: For ASan builds both Debug and Release
configurations are supported.
On 2016/08/26 17:41:01, inferno wrote:
> add a comma after "For ASan builds"

Done.

https://codereview.chromium.org/2280913002/diff/20001/testing/libfuzzer/repro...
testing/libfuzzer/reproducing.md:53: For other planforms
`ffmpeg_branding=Chrome`.
On 2016/08/26 17:41:01, inferno wrote:
> typo: planforms -> platforms.
> s/For other planforms/For other platforms, use

Done.

[mmoroz, 2016-08-28 08:27:12]

The CQ bit was checked by mmoroz@chromium.org

[mmoroz, 2016-08-28 08:27:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
thakis@chromium.org, dalecurtis@chromium.org, inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/2280913002/#ps40001
(title: "Fix grammar and typo.")

[commit-bot: I haz the power, 2016-08-28 08:27:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 08:59:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-28 09:01:03]

Description was changed from

==========
[libfuzzer] Update GN flags for reproducing bugs.

R=dalecurtis@chromium.org, inferno@chromium.org, ochang@chromium.org,
thakis@chromium.org
BUG=640967
==========

to

==========
[libfuzzer] Update GN flags for reproducing bugs.

R=dalecurtis@chromium.org, inferno@chromium.org, ochang@chromium.org,
thakis@chromium.org
BUG=640967

Committed: https://crrev.com/beaf9f5d23523b4c285e73836b38df68165f0f00
Cr-Commit-Position: refs/heads/master@{#414958}
==========

[commit-bot: I haz the power, 2016-08-28 09:01:05]

Patchset 3 (id:??) landed as
https://crrev.com/beaf9f5d23523b4c285e73836b38df68165f0f00
Cr-Commit-Position: refs/heads/master@{#414958}