Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2280883002:
Remove confusing (and apparently wrong) DCHECK from ScopeInfo::Create (Closed)
|
Created:
4 years, 3 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 3 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionRemove confusing (and apparently wrong) DCHECK from ScopeInfo::Create
We should always only have exactly as many heap slots as context locals
R=verwaest@chromium.org,marja@chromium.org
BUG=
Committed: https://crrev.com/64b65578867e52f8dfaedf3eac8d2964a7ca9096
Cr-Commit-Position: refs/heads/master@{#38946}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
(I'll defer this review to verwaest@ since he knows this better than me.)
Can you explain the old meaning of the dcheck so I understand what it was doing and why you are changing it?
On 2016/08/26 at 12:21:46, verwaest wrote: > Can you explain the old meaning of the dcheck so I understand what it was doing and why you are changing it? I have no idea what this was supposed to be.
jochen@chromium.org changed reviewers: + rossberg@chromium.org
+rossberg who added the DCHECK in https://chromiumcodereview.appspot.com/9844002 Andreas, can you explain what this DCHECK checks?
On 2016/08/26 13:00:28, jochen wrote: > +rossberg who added the DCHECK in https://chromiumcodereview.appspot.com/9844002 > > Andreas, can you explain what this DCHECK checks? I don't remember, but this may have been to allow empty modules, which would still have needed a context at the time to store some meta information. I don't know what the situation is now, neis or adamk might know more. It may also have been a bug fix to handle the sloppy direct eval case, I'm not sure. Can you try if the following still works? function f(s) { eval(s); return () => x } f("var x = 5, y = 7")() // = 5
On 2016/08/26 at 13:34:36, rossberg wrote: > On 2016/08/26 13:00:28, jochen wrote: > > +rossberg who added the DCHECK in https://chromiumcodereview.appspot.com/9844002 > > > > Andreas, can you explain what this DCHECK checks? > > I don't remember, but this may have been to allow empty modules, which would still have needed a context at the time to store some meta information. I don't know what the situation is now, neis or adamk might know more. > > It may also have been a bug fix to handle the sloppy direct eval case, I'm not sure. Can you try if the following still works? > > function f(s) { eval(s); return () => x } > f("var x = 5, y = 7")() // = 5 Yeah, that still works. It's not possible to have a non-zero number of heap slots that is less than context min size which in turn is larger than kVariablePartIndex
On 2016/08/26 13:47:45, jochen wrote: > On 2016/08/26 at 13:34:36, rossberg wrote: > > On 2016/08/26 13:00:28, jochen wrote: > > > +rossberg who added the DCHECK in > https://chromiumcodereview.appspot.com/9844002 > > > > > > Andreas, can you explain what this DCHECK checks? > > > > I don't remember, but this may have been to allow empty modules, which would > still have needed a context at the time to store some meta information. I don't > know what the situation is now, neis or adamk might know more. > > > > It may also have been a bug fix to handle the sloppy direct eval case, I'm not > sure. Can you try if the following still works? > > > > function f(s) { eval(s); return () => x } > > f("var x = 5, y = 7")() // = 5 > > Yeah, that still works. > > It's not possible to have a non-zero number of heap slots that is less than > context min size which in turn is larger than kVariablePartIndex LGTM then, I suppose...
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove confusing (and apparently wrong) DCHECK from ScopeInfo::Create We should always only have exactly as many heap slots as context locals R=verwaest@chromium.org,marja@chromium.org BUG= ========== to ========== Remove confusing (and apparently wrong) DCHECK from ScopeInfo::Create We should always only have exactly as many heap slots as context locals R=verwaest@chromium.org,marja@chromium.org BUG= Committed: https://crrev.com/64b65578867e52f8dfaedf3eac8d2964a7ca9096 Cr-Commit-Position: refs/heads/master@{#38946} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/64b65578867e52f8dfaedf3eac8d2964a7ca9096 Cr-Commit-Position: refs/heads/master@{#38946} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
