Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 2280853002: Slightly nicer icon.js APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{canBeDefault: boolean, 6 * @typedef {{canBeDefault: boolean,
7 * canBeEdited: boolean, 7 * canBeEdited: boolean,
8 * canBeRemoved: boolean, 8 * canBeRemoved: boolean,
9 * default: boolean, 9 * default: boolean,
10 * displayName: string, 10 * displayName: string,
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // Construct the name column. 116 // Construct the name column.
117 var nameColEl = this.ownerDocument.createElement('div'); 117 var nameColEl = this.ownerDocument.createElement('div');
118 nameColEl.className = 'name-column'; 118 nameColEl.className = 'name-column';
119 nameColEl.classList.add('weakrtl'); 119 nameColEl.classList.add('weakrtl');
120 this.contentElement.appendChild(nameColEl); 120 this.contentElement.appendChild(nameColEl);
121 121
122 // Add the favicon. 122 // Add the favicon.
123 var faviconDivEl = this.ownerDocument.createElement('div'); 123 var faviconDivEl = this.ownerDocument.createElement('div');
124 faviconDivEl.className = 'favicon'; 124 faviconDivEl.className = 'favicon';
125 if (!this.isPlaceholder) { 125 if (!this.isPlaceholder) {
126 faviconDivEl.style.backgroundImage = cr.icon.getFaviconImageSet( 126 // Force default icon if no iconURL is available.
127 // Force default icon if no iconURL is available. 127 faviconDivEl.style.backgroundImage =
128 engine.iconURL || ''); 128 cr.icon.getFavicon(engine.iconURL || '');
129 } 129 }
130 130
131 nameColEl.appendChild(faviconDivEl); 131 nameColEl.appendChild(faviconDivEl);
132 132
133 var nameEl = this.createEditableTextCell(engine.displayName); 133 var nameEl = this.createEditableTextCell(engine.displayName);
134 nameEl.classList.add('weakrtl'); 134 nameEl.classList.add('weakrtl');
135 nameColEl.appendChild(nameEl); 135 nameColEl.appendChild(nameEl);
136 136
137 // Then the keyword column. 137 // Then the keyword column.
138 var keywordEl = this.createEditableTextCell(engine.keyword); 138 var keywordEl = this.createEditableTextCell(engine.keyword);
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 }, 370 },
371 }; 371 };
372 372
373 // Export 373 // Export
374 return { 374 return {
375 SearchEngineList: SearchEngineList 375 SearchEngineList: SearchEngineList
376 }; 376 };
377 377
378 }); 378 });
379 379
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698