Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: content/browser/compositor/browser_compositor_output_surface.cc

Issue 228083002: Make ReflectorImpl use mailboxes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/browser_compositor_output_surface.cc
diff --git a/content/browser/compositor/browser_compositor_output_surface.cc b/content/browser/compositor/browser_compositor_output_surface.cc
index 6f82df4bb921fdd70f16b86e3b44de91f10649da..b1cdd90e54e068b94c6e7ffe509192199beb3863 100644
--- a/content/browser/compositor/browser_compositor_output_surface.cc
+++ b/content/browser/compositor/browser_compositor_output_surface.cc
@@ -40,6 +40,9 @@ BrowserCompositorOutputSurface::BrowserCompositorOutputSurface(
BrowserCompositorOutputSurface::~BrowserCompositorOutputSurface() {
DCHECK(CalledOnValidThread());
+ if (reflector_)
+ reflector_->DetachFromOutputSurface();
+ DCHECK(!reflector_);
if (!HasClient())
return;
output_surface_map_->Remove(surface_id_);
@@ -62,18 +65,11 @@ bool BrowserCompositorOutputSurface::BindToClient(
output_surface_map_->AddWithID(this, surface_id_);
if (reflector_)
- reflector_->OnSourceSurfaceReady(surface_id_);
+ reflector_->OnSourceSurfaceReady(this);
vsync_manager_->AddObserver(this);
return true;
}
-void BrowserCompositorOutputSurface::Reshape(const gfx::Size& size,
- float scale_factor) {
- OutputSurface::Reshape(size, scale_factor);
- if (reflector_.get())
- reflector_->OnReshape(size);
-}
-
void BrowserCompositorOutputSurface::OnUpdateVSyncParameters(
base::TimeTicks timebase,
base::TimeDelta interval) {

Powered by Google App Engine
This is Rietveld 408576698