Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2280763002: exo: Use aura::Env()->Add{Pre,Post}TargetHandler to simplfy WmHelperMus. (Closed)

Created:
4 years, 3 months ago by Peng
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Use aura::Env()->Add{Pre,Post}TargetHandler to simplfy WmHelperMus. BUG=None Committed: https://crrev.com/61e97d3dd0d1d4be51e3c2bd0cbcd3a9df1bef3e Cr-Commit-Position: refs/heads/master@{#414704}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -63 lines) Patch
M components/exo/wm_helper_mus.h View 3 chunks +0 lines, -16 lines 0 comments Download
M components/exo/wm_helper_mus.cc View 3 chunks +6 lines, -47 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
Peng
David, PTAL. Thanks.
4 years, 3 months ago (2016-08-25 20:06:28 UTC) #4
reveman
https://codereview.chromium.org/2280763002/diff/1/components/exo/wm_helper_mus.cc File components/exo/wm_helper_mus.cc (right): https://codereview.chromium.org/2280763002/diff/1/components/exo/wm_helper_mus.cc#newcode78 components/exo/wm_helper_mus.cc:78: aura::Env::GetInstance()->AddPreTargetHandler(handler); could we use the same for Ash impl ...
4 years, 3 months ago (2016-08-25 20:14:45 UTC) #5
Peng
On 2016/08/25 20:14:45, reveman wrote: > https://codereview.chromium.org/2280763002/diff/1/components/exo/wm_helper_mus.cc > File components/exo/wm_helper_mus.cc (right): > > https://codereview.chromium.org/2280763002/diff/1/components/exo/wm_helper_mus.cc#newcode78 > ...
4 years, 3 months ago (2016-08-26 14:00:23 UTC) #8
reveman
On 2016/08/26 at 14:00:23, penghuang wrote: > On 2016/08/25 20:14:45, reveman wrote: > > https://codereview.chromium.org/2280763002/diff/1/components/exo/wm_helper_mus.cc ...
4 years, 3 months ago (2016-08-26 14:07:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280763002/1
4 years, 3 months ago (2016-08-26 14:10:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 14:14:10 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:15:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61e97d3dd0d1d4be51e3c2bd0cbcd3a9df1bef3e
Cr-Commit-Position: refs/heads/master@{#414704}

Powered by Google App Engine
This is Rietveld 408576698