Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2280753003: Clear |displayed_content_with_cert_errors_| on navigation (Closed)

Created:
4 years, 3 months ago by estark
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear |displayed_content_with_cert_errors_| on navigation I added this flag with the new plumbing for subresources with cert errors in https://crbug.com/634171, but neglected to clear it on navigation. BUG=641180 Committed: https://crrev.com/73583c0beffde96c6797a59fd7f3576ab5f39230 Cr-Commit-Position: refs/heads/master@{#415345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/test/data/ssl/page_with_subresource.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
estark
jam, PTAL?
4 years, 3 months ago (2016-08-26 00:12:21 UTC) #3
estark
Friendly ping
4 years, 3 months ago (2016-08-30 01:13:36 UTC) #7
jam
lgtm (was ooo)
4 years, 3 months ago (2016-08-30 16:35:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280753003/1
4 years, 3 months ago (2016-08-30 16:37:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:52:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:54:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73583c0beffde96c6797a59fd7f3576ab5f39230
Cr-Commit-Position: refs/heads/master@{#415345}

Powered by Google App Engine
This is Rietveld 408576698