Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2280743002:
Add CdmKeyStatus::RELEASED to mojo (Closed)
|
Created:
4 years, 3 months ago by yucliu1 Modified:
4 years, 3 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review), halliwell Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd CdmKeyStatus::RELEASED to mojo
Status is needed for session removal in remote cdm.
BUG=
TEST=No check failure when remove session on chromecast.
Committed: https://crrev.com/cd58a0afe542436357e431ee8245018d9178670e
Cr-Commit-Position: refs/heads/master@{#414613}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Type converter #
Total comments: 2
Messages
Total messages: 19 (7 generated)
Description was changed from ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. ========== to ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. ==========
yucliu@chromium.org changed reviewers: + dcheng@chromium.org, xhwang@chromium.org
Thanks! One comment :) https://codereview.chromium.org/2280743002/diff/1/media/mojo/interfaces/conte... File media/mojo/interfaces/content_decryption_module.mojom (right): https://codereview.chromium.org/2280743002/diff/1/media/mojo/interfaces/conte... media/mojo/interfaces/content_decryption_module.mojom:32: RELEASED Please also update the type converter: https://cs.chromium.org/chromium/src/media/mojo/common/media_type_converters....
https://codereview.chromium.org/2280743002/diff/1/media/mojo/interfaces/conte... File media/mojo/interfaces/content_decryption_module.mojom (right): https://codereview.chromium.org/2280743002/diff/1/media/mojo/interfaces/conte... media/mojo/interfaces/content_decryption_module.mojom:32: RELEASED On 2016/08/25 19:11:40, xhwang (slow) wrote: > Please also update the type converter: > > https://cs.chromium.org/chromium/src/media/mojo/common/media_type_converters.... Done.
lgtm
The CQ bit was checked by yucliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2280743002/diff/20001/media/mojo/common/media... File media/mojo/common/media_type_converters.cc (right): https://codereview.chromium.org/2280743002/diff/20001/media/mojo/common/media... media/mojo/common/media_type_converters.cc:320: ASSERT_CDM_KEY_STATUS(RELEASED); What's the status on moving to EnumTraits?
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/2280743002/diff/20001/media/mojo/common/media... File media/mojo/common/media_type_converters.cc (right): https://codereview.chromium.org/2280743002/diff/20001/media/mojo/common/media... media/mojo/common/media_type_converters.cc:320: ASSERT_CDM_KEY_STATUS(RELEASED); On 2016/08/25 22:21:02, dcheng wrote: > What's the status on moving to EnumTraits? Yeah, we are behind. Can you file a bug and assign to me. I think we can get this (and probably others) fixed in M55.
mojo changes lgtm, it sounds like the typemapping stuff will be addressed
The CQ bit was checked by yucliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. ========== to ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. ========== to ========== Add CdmKeyStatus::RELEASED to mojo Status is needed for session removal in remote cdm. BUG= TEST=No check failure when remove session on chromecast. Committed: https://crrev.com/cd58a0afe542436357e431ee8245018d9178670e Cr-Commit-Position: refs/heads/master@{#414613} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cd58a0afe542436357e431ee8245018d9178670e Cr-Commit-Position: refs/heads/master@{#414613} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
