chrome/renderer/extensions/messaging_bindings.cc - Issue 228073005: Move core extensions l10n code to //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/messaging_bindings.cc

Issue 228073005: Move core extensions l10n code to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/messaging_bindings.cc

diff --git a/chrome/renderer/extensions/messaging_bindings.cc b/chrome/renderer/extensions/messaging_bindings.cc

index 273718758cf92eec6d171b87142bd0c987a8cb9e..894b5472d57c54f142de9859760f0772a910b38f 100644

--- a/chrome/renderer/extensions/messaging_bindings.cc

+++ b/chrome/renderer/extensions/messaging_bindings.cc

@@ -14,7 +14,6 @@

#include "base/message_loop/message_loop.h"

#include "base/values.h"

#include "chrome/common/extensions/manifest_handlers/externally_connectable.h"

-#include "chrome/common/extensions/message_bundle.h"

#include "chrome/common/url_constants.h"

#include "chrome/renderer/extensions/chrome_v8_context.h"

#include "chrome/renderer/extensions/chrome_v8_context_set.h"

@@ -26,6 +25,7 @@

#include "content/public/renderer/v8_value_converter.h"

#include "extensions/common/api/messaging/message.h"

#include "extensions/common/extension_messages.h"

+#include "extensions/common/message_bundle.h"

Yoyo Zhou 2014/04/08 18:47:44 Is this actually used here?

Ken Rockot(use gerrit already) 2014/04/08 19:31:46 Nope, nice catch. Removed.

#include "extensions/renderer/scoped_persistent.h"

#include "grit/renderer_resources.h"

#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"