Move core extensions l10n code to //extensions

extensions/common/extension_l10n_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/chrome_paths.h"
-#include "chrome/common/extensions/extension_l10n_util.h"
-#include "chrome/common/extensions/message_bundle.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
+#include "extensions/common/extension_l10n_util.h"
 #include "extensions/common/manifest_constants.h"
+#include "extensions/common/message_bundle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using extensions::kLocaleFolder;
 using extensions::kMessagesFilename;
 using extensions::MessageBundle;
 
 namespace errors = extensions::manifest_errors;
 namespace keys = extensions::manifest_keys;
@@ skipping 10 matching lines @@
 
   base::FilePath messages_file = locale.Append(kMessagesFilename);
   std::string data = "{ \"name\":";
   ASSERT_TRUE(base::WriteFile(messages_file, data.c_str(), data.length()));
 
   base::DictionaryValue manifest;
   manifest.SetString(keys::kDefaultLocale, "en");
   std::string error;
   EXPECT_FALSE(extension_l10n_util::ValidateExtensionLocales(
       temp.path(), &manifest, &error));
-  EXPECT_THAT(error,
-              testing::HasSubstr(
-                  base::UTF16ToUTF8(messages_file.LossyDisplayName())));
+  EXPECT_THAT(
+      error,
+      testing::HasSubstr(base::UTF16ToUTF8(messages_file.LossyDisplayName())));
 }
 
 TEST(ExtensionL10nUtil, GetValidLocalesEmptyLocaleFolder) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::string error;
   std::set<std::string> locales;
-  EXPECT_FALSE(extension_l10n_util::GetValidLocales(src_path,
-                                                    &locales,
-                                                    &error));
+  EXPECT_FALSE(
+      extension_l10n_util::GetValidLocales(src_path, &locales, &error));
 
   EXPECT_TRUE(locales.empty());
 }
 
 TEST(ExtensionL10nUtil, GetValidLocalesWithValidLocaleNoMessagesFile) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
   ASSERT_TRUE(base::CreateDirectory(src_path.AppendASCII("sr")));
 
   std::string error;
   std::set<std::string> locales;
-  EXPECT_FALSE(extension_l10n_util::GetValidLocales(src_path,
-                                                    &locales,
-                                                    &error));
+  EXPECT_FALSE(
+      extension_l10n_util::GetValidLocales(src_path, &locales, &error));
 
   EXPECT_TRUE(locales.empty());
 }
 
 TEST(ExtensionL10nUtil, GetValidLocalesWithUnsupportedLocale) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
   // Supported locale.
   base::FilePath locale_1 = src_path.AppendASCII("sr");
   ASSERT_TRUE(base::CreateDirectory(locale_1));
   std::string data("whatever");
   ASSERT_TRUE(base::WriteFile(
-      locale_1.Append(kMessagesFilename),
-      data.c_str(), data.length()));
+      locale_1.Append(kMessagesFilename), data.c_str(), data.length()));
   // Unsupported locale.
   ASSERT_TRUE(base::CreateDirectory(src_path.AppendASCII("xxx_yyy")));
 
   std::string error;
   std::set<std::string> locales;
-  EXPECT_TRUE(extension_l10n_util::GetValidLocales(src_path,
-                                                   &locales,
-                                                   &error));
+  EXPECT_TRUE(extension_l10n_util::GetValidLocales(src_path, &locales, &error));
 
   EXPECT_FALSE(locales.empty());
   EXPECT_TRUE(locales.find("sr") != locales.end());
   EXPECT_FALSE(locales.find("xxx_yyy") != locales.end());
 }
 
 TEST(ExtensionL10nUtil, GetValidLocalesWithValidLocalesAndMessagesFile) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &install_dir));
   install_dir = install_dir.AppendASCII("extensions")
-      .AppendASCII("good")
-      .AppendASCII("Extensions")
-      .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
-      .AppendASCII("1.0.0.0")
-      .Append(kLocaleFolder);
+                    .AppendASCII("good")
+                    .AppendASCII("Extensions")
+                    .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
+                    .AppendASCII("1.0.0.0")
+                    .Append(kLocaleFolder);
 
   std::string error;
   std::set<std::string> locales;
-  EXPECT_TRUE(extension_l10n_util::GetValidLocales(install_dir,
-                                                   &locales,
-                                                   &error));
+  EXPECT_TRUE(
+      extension_l10n_util::GetValidLocales(install_dir, &locales, &error));
   EXPECT_EQ(3U, locales.size());
   EXPECT_TRUE(locales.find("sr") != locales.end());
   EXPECT_TRUE(locales.find("en") != locales.end());
   EXPECT_TRUE(locales.find("en_US") != locales.end());
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsValidFallback) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &install_dir));
   install_dir = install_dir.AppendASCII("extensions")
-      .AppendASCII("good")
-      .AppendASCII("Extensions")
-      .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
-      .AppendASCII("1.0.0.0")
-      .Append(kLocaleFolder);
+                    .AppendASCII("good")
+                    .AppendASCII("Extensions")
+                    .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
+                    .AppendASCII("1.0.0.0")
+                    .Append(kLocaleFolder);
 
   std::string error;
   std::set<std::string> locales;
-  EXPECT_TRUE(extension_l10n_util::GetValidLocales(install_dir,
-                                                   &locales,
-                                                   &error));
+  EXPECT_TRUE(
+      extension_l10n_util::GetValidLocales(install_dir, &locales, &error));
 
   scoped_ptr<MessageBundle> bundle(extension_l10n_util::LoadMessageCatalogs(
       install_dir, "sr", "en_US", locales, &error));
   ASSERT_FALSE(NULL == bundle.get());
   EXPECT_TRUE(error.empty());
   EXPECT_EQ("Color", bundle->GetL10nMessage("color"));
   EXPECT_EQ("Not in the US or GB.", bundle->GetL10nMessage("not_in_US_or_GB"));
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsMissingFiles) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::set<std::string> valid_locales;
   valid_locales.insert("sr");
   valid_locales.insert("en");
   std::string error;
-  EXPECT_TRUE(NULL == extension_l10n_util::LoadMessageCatalogs(src_path,
-                                                               "en",
-                                                               "sr",
-                                                               valid_locales,
-                                                               &error));
+  EXPECT_TRUE(NULL == extension_l10n_util::LoadMessageCatalogs(
+                          src_path, "en", "sr", valid_locales, &error));
   EXPECT_FALSE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsBadJSONFormat) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   base::FilePath locale = src_path.AppendASCII("sr");
   ASSERT_TRUE(base::CreateDirectory(locale));
 
   std::string data = "{ \"name\":";
   base::FilePath messages_file = locale.Append(kMessagesFilename);
   ASSERT_TRUE(base::WriteFile(messages_file, data.c_str(), data.length()));
 
   std::set<std::string> valid_locales;
   valid_locales.insert("sr");
   valid_locales.insert("en_US");
   std::string error;
-  EXPECT_TRUE(NULL == extension_l10n_util::LoadMessageCatalogs(src_path,
-                                                               "en_US",
-                                                               "sr",
-                                                               valid_locales,
-                                                               &error));
-  EXPECT_EQ(
-      extensions::ErrorUtils::FormatErrorMessage(
-          errors::kLocalesInvalidLocale,
-          base::UTF16ToUTF8(messages_file.LossyDisplayName()),
-          "Line: 1, column: 10, Unexpected token."),
-      error);
+  EXPECT_TRUE(NULL == extension_l10n_util::LoadMessageCatalogs(
+                          src_path, "en_US", "sr", valid_locales, &error));
+  EXPECT_EQ(extensions::ErrorUtils::FormatErrorMessage(
+                errors::kLocalesInvalidLocale,
+                base::UTF16ToUTF8(messages_file.LossyDisplayName()),
+                "Line: 1, column: 10, Unexpected token."),
+            error);
 }
 
 TEST(ExtensionL10nUtil, LoadMessageCatalogsDuplicateKeys) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   base::FilePath src_path = temp.path().Append(kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   base::FilePath locale_1 = src_path.AppendASCII("en");
   ASSERT_TRUE(base::CreateDirectory(locale_1));
 
   std::string data =
-    "{ \"name\": { \"message\": \"something\" }, "
-    "\"name\": { \"message\": \"something else\" } }";
-  ASSERT_TRUE(base::WriteFile(locale_1.Append(kMessagesFilename),
-                              data.c_str(), data.length()));
+      "{ \"name\": { \"message\": \"something\" }, "
+      "\"name\": { \"message\": \"something else\" } }";
+  ASSERT_TRUE(base::WriteFile(
+      locale_1.Append(kMessagesFilename), data.c_str(), data.length()));
 
   base::FilePath locale_2 = src_path.AppendASCII("sr");
   ASSERT_TRUE(base::CreateDirectory(locale_2));
 
-  ASSERT_TRUE(base::WriteFile(locale_2.Append(kMessagesFilename),
-                              data.c_str(), data.length()));
+  ASSERT_TRUE(base::WriteFile(
+      locale_2.Append(kMessagesFilename), data.c_str(), data.length()));
 
   std::set<std::string> valid_locales;
   valid_locales.insert("sr");
   valid_locales.insert("en");
   std::string error;
   // JSON parser hides duplicates. We are going to get only one key/value
   // pair at the end.
   scoped_ptr<MessageBundle> message_bundle(
-      extension_l10n_util::LoadMessageCatalogs(src_path,
-                                               "en",
-                                               "sr",
-                                               valid_locales,
-                                               &error));
+      extension_l10n_util::LoadMessageCatalogs(
+          src_path, "en", "sr", valid_locales, &error));
   EXPECT_TRUE(NULL != message_bundle.get());
   EXPECT_TRUE(error.empty());
 }
 
 // Caller owns the returned object.
 MessageBundle* CreateManifestBundle() {
   linked_ptr<base::DictionaryValue> catalog(new base::DictionaryValue);
 
   base::DictionaryValue* name_tree = new base::DictionaryValue();
   name_tree->SetString("message", "name");
@@ skipping 259 matching lines @@
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
   ASSERT_TRUE(manifest.GetString(keys::kName, &result));
   EXPECT_EQ("name", result);
 
   ASSERT_TRUE(manifest.GetString(keys::kDescription, &result));
   EXPECT_EQ("description", result);
 
-  ASSERT_TRUE(manifest.GetString("commands.first_command.description",
-                                 &result));
+  ASSERT_TRUE(
+      manifest.GetString("commands.first_command.description", &result));
   EXPECT_EQ("first command", result);
 
-  ASSERT_TRUE(manifest.GetString("commands.second_command.description",
-                                 &result));
+  ASSERT_TRUE(
+      manifest.GetString("commands.second_command.description", &result));
   EXPECT_EQ("second command", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithShortName) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "extension name");
   manifest.SetString(keys::kShortName, "__MSG_short_name__");
 
@@ skipping 132 matching lines @@
   std::vector<std::string> fallback_locales;
   extension_l10n_util::GetAllFallbackLocales("en_US", "all", &fallback_locales);
   ASSERT_EQ(3U, fallback_locales.size());
 
   CHECK_EQ("en_US", fallback_locales[0]);
   CHECK_EQ("en", fallback_locales[1]);
   CHECK_EQ("all", fallback_locales[2]);
 }
 
 }  // namespace