Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228073005: Move core extensions l10n code to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, yoshiki+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move core extensions l10n code to //extensions There are three important changes in this CL, all interdependent enough that it seemed best to tackle them at the same time. 1. message_bundle moves to //extensions. (mechanical) 2. extension_l10n_util moves to //extensions. (mechanical) 3. MessageBundle-related functionality from //chrome/c/e/extension_file_util has been moved into //extensions/common/file_util to support the move of extension_l10n_util. BUG=359836 TBR=sky@chromium.org for chrome/utility, browser_process_impl TBR=kalman@chromium.org for tabs API TBR=zork@chromium.org for //c/b/chromeos/input_method TBR=satorux@chromium.org for //c/b/chromeos/e/file_manager Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262552

Patch Set 1 #

Total comments: 2

Patch Set 2 : unused header is unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -2466 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/execute_code_function.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.h View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +1 line, -57 lines 0 comments Download
D chrome/common/extensions/extension_l10n_util.h View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/common/extensions/extension_l10n_util.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D chrome/common/extensions/extension_l10n_util_unittest.cc View 1 chunk +0 lines, -679 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/message_bundle.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/common/extensions/message_bundle.cc View 1 chunk +0 lines, -348 lines 0 comments Download
D chrome/common/extensions/message_bundle_unittest.cc View 1 chunk +0 lines, -434 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/messaging_bindings.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/utility/extensions/unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/extension_l10n_util.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/common/extension_l10n_util.cc View 14 chunks +28 lines, -33 lines 0 comments Download
A + extensions/common/extension_l10n_util_unittest.cc View 12 chunks +46 lines, -63 lines 0 comments Download
M extensions/common/file_util.h View 2 chunks +17 lines, -0 lines 0 comments Download
M extensions/common/file_util.cc View 2 chunks +62 lines, -0 lines 0 comments Download
A + extensions/common/message_bundle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/message_bundle.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/message_bundle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ken Rockot(use gerrit already)
Yoyo can you PTAL?
6 years, 8 months ago (2014-04-08 17:28:37 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/228073005/diff/1/chrome/renderer/extensions/messaging_bindings.cc File chrome/renderer/extensions/messaging_bindings.cc (right): https://codereview.chromium.org/228073005/diff/1/chrome/renderer/extensions/messaging_bindings.cc#newcode28 chrome/renderer/extensions/messaging_bindings.cc:28: #include "extensions/common/message_bundle.h" Is this actually used here?
6 years, 8 months ago (2014-04-08 18:47:44 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/228073005/diff/1/chrome/renderer/extensions/messaging_bindings.cc File chrome/renderer/extensions/messaging_bindings.cc (right): https://codereview.chromium.org/228073005/diff/1/chrome/renderer/extensions/messaging_bindings.cc#newcode28 chrome/renderer/extensions/messaging_bindings.cc:28: #include "extensions/common/message_bundle.h" On 2014/04/08 18:47:44, Yoyo Zhou wrote: > ...
6 years, 8 months ago (2014-04-08 19:31:45 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-08 19:31:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/228073005/20001
6 years, 8 months ago (2014-04-08 19:32:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 20:20:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=130819
6 years, 8 months ago (2014-04-08 20:20:34 UTC) #7
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-08 20:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/228073005/20001
6 years, 8 months ago (2014-04-08 20:55:34 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 23:32:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 262552

Powered by Google App Engine
This is Rietveld 408576698